Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use run-dependent bad channels for CSC, HCAL and strips #33074

Merged

Conversation

christopheralanwest
Copy link
Contributor

PR description:

This PR adds run dependent tags to the 2018 run-dependent MC queue that represent bad channels for CSC, HCAL and strips. This GT will be used in an upcoming test of the run-dependent MC procedure.

At this point, a simplified IOV structure with equally weighted IOVs is being used and so the HCAL tag only approximately represents the appropriate luminosity weighting of the HEM15/HEM16 failure and non-failure periods. Both the CSC and strips tags have minor technical changes that represent small deviations from 2018 for the purpose of validating the run-dependent machinery. All three will require updates once a more realistic 2018 IOV weighting is supported.

The GT diff is as follows:

2018 realistic (run-dependent)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_upgrade2018_realistic_RD_v2/113X_upgrade2018_realistic_RD_v3

PR validation:

See the presentations at the 22 Feb 2021 AlCaDB meeting for details.

In addition, a technical test was performed: runTheMatrix.py -l 250202.183 --ibeos

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is not a backport and should not be backported.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33074/21386

  • This PR adds an extra 12KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2021

A new Pull Request was created by @christopheralanwest for master.

It involves the following packages:

Configuration/AlCa

@malbouis, @yuanchao, @christopheralanwest, @cmsbuild, @tlampen, @pohsun, @francescobrivio can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@christopheralanwest
Copy link
Contributor Author

test parameters

  • workflow = 250202.183

@christopheralanwest
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-64c7df/13282/summary.html
COMMIT: 0465632
CMSSW: CMSSW_11_3_X_2021-03-04-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33074/13282/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-64c7df/250202.183_TTbar_13UP18_RD+TTbar_13UP18_RD+DIGIPRMXUP18_PU25_RD_IB+RECOPRMXUP18_PU25_RD+HARVESTUP18_PU25_RD

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2867 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2748956
  • DQMHistoTests: Total failures: 64469
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2684465
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

@christopheralanwest
Copy link
Contributor Author

+1

  • 2018 run-dependent MC GT includes updates desired for run-dependent MC tests
  • comparison test differences arise from a reproducibility issue unrelated to this PR

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Mar 5, 2021

+1

@cmsbuild cmsbuild merged commit 9126a73 into cms-sw:master Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants