Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caloparticle debugger improvements #33081

Merged
merged 4 commits into from Mar 5, 2021

Conversation

rovere
Copy link
Contributor

@rovere rovere commented Mar 5, 2021

PR description:

Improve the CaloParticleDebugger module by:

  • Add information on crossedBoundary for the SimTracks collection
  • sending output via LogVerbatim and not directly to std::cout
  • Exploit the improved MessageLogger configuration capabilities to have the output of each monitored collection saved into a separate file
  • Add argument parsing to the python script.

PR validation:

Private tests, since this debugging module is not used in any workflow.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33081/21394

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2021

A new Pull Request was created by @rovere (Marco Rovere) for master.

It involves the following packages:

SimGeneral/Debugging

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@rovere
Copy link
Contributor Author

rovere commented Mar 5, 2021

@cmsbuild please test

@rovere rovere changed the title Calo particle debugger improvements Caloparticle debugger improvements Mar 5, 2021
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ceb90c/13295/summary.html
COMMIT: d0ce485
CMSSW: CMSSW_11_3_X_2021-03-04-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33081/13295/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-ceb90c/34634.0_TTbar_14TeV+2026D76+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-ceb90c/34834.999_TTbar_14TeV+2026D76PU_PMXS1S2PR+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+PREMIX_PremixHLBeamSpot14PU+DigiTriggerPU+RecoGlobalPU+HARVESTGlobalPU

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3001 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2849195
  • DQMHistoTests: Total failures: 64883
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2784290
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files

@civanch
Copy link
Contributor

civanch commented Mar 5, 2021

+1

differences all in DD4Hep workflow

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Mar 5, 2021

+1

@cmsbuild cmsbuild merged commit 312f9a0 into cms-sw:master Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants