Add interactive option to runTheMatrix #33082
Conversation
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33082/21397
|
|
A new Pull Request was created by @rovere (Marco Rovere) for master. It involves the following packages: Configuration/PyReleaseValidation @jordan-martins, @chayanit, @wajidalikhan, @kpedro88, @cmsbuild, @srimanob can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b1acaa/13301/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
|
Any comments about this? |
|
I'm not sure the use of this interactive attribute. Could you show me what you get from running runTheMatrix.py --interactive? |
|
Ciao @chayanit To expand a bit: in order to try this out, you need to locally merge this PR and issue the command:
There should be help available for you at the prompt by typing Thanks a lot! |
|
Hello @rovere , sorry for some silence. We have been busy in recent requests and tasks. I have tried your proposed interactive option but still do not get how this can be helpful. It would be nice if you can demonstrate a bit? I got the following from ? or help but I don't know what next. Let's say if I wanna searchInWorkflow, how and what to put in. Documented commands (type help ):clear dumpWorkflowId help predefined search searchInWorkflow showWorkflow Undocumented commands:EOF exit |
|
Thanks a lot, @chayanit for taking the time to try and test it. you'll get an explanation of the command together with its correct syntax. So, if you want to know all workflows that use the geometry The search terms in this and in all other commands should be valid regular expressions. Those are, IMHO, the most powerful tool for this kind of job. Maybe not the most intuitive one, if you are not too familiar with them. If, instead, you would like to limit the search to a specific macro area, e.g. relval_upgrade, you could use the same regular expression but a different command: Suppose now that you want to know what are the commands run by the workflow The The last command is All commands come with dynamic TAB-completion. There's also a transient history of the commands issues within a single session. I hope this clarifies a bit more about the usage of the interactive shell. Let me know if you have additional questions. |
|
Ciao @chayanit and also all others involved in this thread: do you think this could be a useful improvement to have in release? |
|
Hello @rovere , sorry for some silence. I have been very busy recently. I found this interactive option is very nice after your explanation. Would you mind to create README to document the usage of this interactive option? And I think it's ready :) |
|
Do we need any protection that this option should not be used with others? |
|
Ciao @chayanit, adding a README file seems a nice improvement. Where would you suggest placing it? Directly in the very same directory as the |
I would say so :) |
cmsbuild
added
code-checks-pending
tests-pending
and removed
code-checks-approved
tests-approved
labels
|
I added a README file with some instructions/explanation about the |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33082/21802
|
|
Pull request #33082 was updated. @jordan-martins, @chayanit, @wajidalikhan, @kpedro88, @cmsbuild, @srimanob can you please check and sign again. |
|
@cmsbuild please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b1acaa/13817/summary.html Comparison SummaryThe workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons Summary:
|
|
+1 |
|
+Upgrade |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
cmsbuild
added
fully-signed
upgrade-approved
and removed
pending-signatures
upgrade-pending
labels
|
+1 |
PR description:
This PR introduces the
interactive shelloption torunTheMatrix. To enter the shell, use the command:I regularly find myself searching for a particular combination of geometry, release, samples, whatever in the rather complete set of samples we can generate with
runTheMatrix.While everything can be (more or less easily) performed piping the output to
less,grepand similar tools, I thought it would have been nice to have an interactive shell where the user can explore all the possibilities of samples andmacrosamples available throughrunTheMatrixin an interactive way.The amount of commands implemented is rather limited but cover the use cases I needed the most.
PR validation:
I tried an interactive session. I'm not sure how to test this in a systematic way.