Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of git-publish #33112

Merged
merged 1 commit into from Mar 15, 2021
Merged

Conversation

silviodonato
Copy link
Contributor

PR description:

Follow-up of #32917 (comment) by @smuzaffar :

I think Utilities/ReleaseScripts/scripts/git-publish is not used and can be dropped. It has the old categories name (CVS era). Most of this is now part of git-cms-tools.

cc @cms-sw/core-l2

PR validation:

scram b runtests

if this PR is a backport please specify the original PR and why you need to backport that PR:

No backport expected

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33112/21454

  • This PR adds an extra 12KB to repository

@silviodonato
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2021

A new Pull Request was created by @silviodonato (Silvio Donato) for master.

It involves the following packages:

Utilities/ReleaseScripts

@makortel, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@wddgit this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-76f358/13373/summary.html
COMMIT: 384af2e
CMSSW: CMSSW_11_3_X_2021-03-08-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33112/13373/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2849195
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2849166
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files

@silviodonato
Copy link
Contributor Author

kind reminder @cms-sw/core-l2 . If you prefer we can mention this PR at the ORP meeting, just to be sure nobody needs it.

@makortel
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Mar 15, 2021

+1

@cmsbuild cmsbuild merged commit 8efd6a2 into cms-sw:master Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants