Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate CosmicGenFilterHelix to esConsumes #33114

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Mar 9, 2021

PR description:

Title says it all.
Part of #31061.

PR validation:

It compiles. Run runTheMatrix.py -l 7.3 -j 8

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport, no backport is needed.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33114/21456

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2021

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

GeneratorInterface/GenFilters

@SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Mar 9, 2021

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ed5c45/13376/summary.html
COMMIT: c6467af
CMSSW: CMSSW_11_3_X_2021-03-08-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33114/13376/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2849195
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2849164
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 37 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 160 log files, 37 edm output root files, 38 DQM output files

@agrohsje
Copy link

agrohsje commented Mar 9, 2021

+generators

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Mar 10, 2021

+1

@cmsbuild cmsbuild merged commit 835a0cf into cms-sw:master Mar 10, 2021
@mmusich mmusich deleted the migrateCosmicGenFilterHelixToESConsumes branch March 10, 2021 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants