[RPC] Bug fix DQM/RPCMonitorClient crash due to type conversion -1 to unsigned int

[Somhammer]

PR description:

It follows up the PR #33017.

PR validation:

scram b -j 10

@jhgoh @jfernan2 @silviodonato

[silviodonato]

please test

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33115/21457

• This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33115/21457/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33115/21457/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[silviodonato]

@Somhammer please run the code fixes pointed by #33115 (comment)

[Somhammer]

@silviodonato I modified the code but this pr is based on @jhgoh's repository. So I made PR in his repository to update. But if you have any good solution more than this, please let me know.

[qliphy]

@Somhammer As mentioned by @silviodonato , would you please follow the suggestion to apply the patch?
"code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33115/21457/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33115/21457/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly"

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33115/21482

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @Somhammer (Seohyeon) for master.

It involves the following packages:

DQM/RPCMonitorClient

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@acimmino this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[silviodonato]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4c0ffe/13404/summary.html
COMMIT: 953847a
CMSSW: CMSSW_11_3_X_2021-03-09-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33115/13404/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2849195
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2849164
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -2.144 KiB( 37 files compared)
• DQMHistoSizes: changed ( 10024.0,... ): -0.105 KiB RPC/DCSInfo
• DQMHistoSizes: changed ( 136.793 ): -0.012 KiB RPC/DCSInfo
• DQMHistoSizes: changed ( 140.56 ): -0.035 KiB RPC/DCSInfo
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 160 log files, 37 edm output root files, 38 DQM output files

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1