Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilities/StaticAnalyzers: group callstacks in EventSetupRecord::get report by package directory and producer #33122

Merged
merged 7 commits into from Mar 16, 2021

Conversation

gartung
Copy link
Member

@gartung gartung commented Mar 9, 2021

Callstacks in EventSetupRecord::get report are now grouped by package directory and producer and output as a yaml file

PhysicsTools/NanoAOD:
  L1TriggerResultsConverter:
  - 'L1TriggerResultsConverter::beginRun(); '
PhysicsTools/PatAlgos:
  pat::JetCorrFactorsProducer:
  - 'pat::JetCorrFactorsProducer::produce(); '
  pat::PATElectronProducer:
  - 'pat::PATElectronProducer::produce(); '
  pat::PATElectronSlimmer:
  - 'pat::PATElectronSlimmer::produce(); pat::ObjectModifier<pat::Electron>::setEventContent();
    ModifyObjectValueBase::setEventContent() virtual; EGRegressionModifierV3::setEventContent(); '

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33122/21472

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2021

A new Pull Request was created by @gartung (Patrick Gartung) for master.

It involves the following packages:

Utilities/StaticAnalyzers

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @wddgit this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33122/21473

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2021

Pull request #33122 was updated. @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33122/21475

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2021

Pull request #33122 was updated. @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33122/21478

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33122/21516

  • This PR adds an extra 16KB to repository

  • Found files with invalid states:

    • Utilities/StaticAnalyzers/scripts/module_to_package.txt:

@cmsbuild
Copy link
Contributor

Pull request #33122 was updated. @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please check and sign again.

@gartung
Copy link
Member Author

gartung commented Mar 11, 2021

@makortel Can you please sign off on this PR.

@gartung
Copy link
Member Author

gartung commented Mar 11, 2021

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9cf2fd/13447/summary.html
COMMIT: 85a575c
CMSSW: CMSSW_11_3_X_2021-03-10-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33122/13447/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2635087
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2635064
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 155 log files, 37 edm output root files, 37 DQM output files

@smuzaffar
Copy link
Contributor

@gartung looks good. By the way, this is not run in PR tests and can only be tested in IBs ... right?

@gartung
Copy link
Member Author

gartung commented Mar 12, 2021

Correct. Only for IB's.

@makortel
Copy link
Contributor

@smuzaffar This can be merged, right?

@smuzaffar
Copy link
Contributor

+core
@makortel this looks good to go.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Mar 16, 2021

+1

@cmsbuild cmsbuild merged commit c50c90f into cms-sw:master Mar 16, 2021
@gartung gartung deleted the gartung-SA-module-2-esrget branch March 16, 2021 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants