Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HLT common customisations to handle SwitchProducers #33138

Merged

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Mar 10, 2021

PR description:

Update the HLT common customisations to discover the EDProducers nested within a SwitchProducer.

PR validation:

HLT customisations now apply the required changes also to nested EDProducers.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport #33137 .

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 10, 2021

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_11_2_X.

It involves the following packages:

HLTrigger/Configuration

@Martin-Grunewald, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 10, 2021

backport #33137

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 10, 2021

type bug-fix

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 10, 2021

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0aac54/13421/summary.html
COMMIT: dc18847
CMSSW: CMSSW_11_2_X_2021-03-10-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33138/13421/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2527501
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2527472
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 35 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 151 log files, 37 edm output root files, 36 DQM output files

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 11, 2021

+hlt

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 11, 2021

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Mar 11, 2021

+1

@cmsbuild cmsbuild merged commit cd1382a into cms-sw:CMSSW_11_2_X Mar 11, 2021
@fwyzard fwyzard deleted the update_HLT_common_customisation_112x branch August 18, 2021 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants