Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove boost/filesystem usage #33144

Merged
merged 4 commits into from Mar 18, 2021
Merged

remove boost/filesystem usage #33144

merged 4 commits into from Mar 18, 2021

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Mar 10, 2021

Cleanup boost/filesystem usage. With new boost version 1.75 , boost filesystem makes use of statx (if available on the build machine) and fails if run on a machine without it. The PR proposes to drop boost filesystem usage and replace it with std::filesystem

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33144/21509

  • This PR adds an extra 52KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33144/21510

  • This PR adds an extra 52KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

CondCore/Utilities
DQMServices/FwkIO
DQMServices/StreamerIO
EventFilter/Utilities
HLTrigger/Tools
PhysicsTools/MXNet
PhysicsTools/ONNXRuntime
PhysicsTools/TensorFlow
RecoLuminosity/LumiProducer
Utilities/LStoreAdaptor

@perrotta, @smuzaffar, @andrius-k, @Dr15Jones, @makortel, @fwyzard, @emeschi, @ErnestaP, @ahmad3213, @Martin-Grunewald, @jpata, @cmsbuild, @jfernan2, @kmaeshima, @slava77, @ggovi, @smorovic, @rvenditti can you please review it and eventually sign? Thanks.
@barvic, @makortel, @riga, @wddgit, @Martin-Grunewald, @hqucms, @mmusich this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-896f24/13434/summary.html
COMMIT: ab3b841
CMSSW: CMSSW_11_3_X_2021-03-10-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33144/13434/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2849195
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2849172
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files

@makortel
Copy link
Contributor

+1

@perrotta
Copy link
Contributor

+1

  • Technical
  • Jenkins tests pass

@smuzaffar
Copy link
Contributor Author

+core

@jfernan2
Copy link
Contributor

+1

@Martin-Grunewald
Copy link
Contributor

+1

@silviodonato
Copy link
Contributor

kind reminder @ggovi @cms-sw/daq-l2

@smorovic
Copy link
Contributor

+1

@qliphy
Copy link
Contributor

qliphy commented Mar 16, 2021

ping @cms-sw/db-l2

@ggovi
Copy link
Contributor

ggovi commented Mar 18, 2021

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Mar 18, 2021

+1

@cmsbuild cmsbuild merged commit 5e6cd3a into cms-sw:master Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet