Rewrite SimActivityRegistryEnroller with variadic types

[davidlange6]

Should remove the last use of boost/mpl in cmssw.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33202/21627

• This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33202/21627/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33202/21627/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33202/21628

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

SimG4Core/Notification

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @cvuosalo, @rovere, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[davidlange6]

please test

…

On Mar 17, 2021, at 11:00 AM, cmsbuild ***@***.***> wrote: A new Pull Request was created by @davidlange6 (David Lange) for master. It involves the following packages: SimG4Core/Notification @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. @makortel, @cvuosalo, @rovere, @fabiocos, @slomeo this is something you requested to watch as well. @silviodonato, @dpiparo, @qliphy you are the release manager for this. cms-bot commands are listed here — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[civanch]

@davidlange6 , do we really need this complicate signals?

[davidlange6]

You mean the original structure? I don’t know. Its now less complex than previously in my judgement.

…

On Mar 17, 2021, at 12:39 PM, Vladimir Ivantchenko ***@***.***> wrote: @davidlange6 , do we really need this complicate signals? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-349639/13568/summary.html
COMMIT: 4d7cd73
CMSSW: CMSSW_11_3_X_2021-03-16-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33202/13568/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2639881
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2639858
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[makortel]

Is this file necessary?

[davidlange6]

whoops! will fix that

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33202/21644

• This PR adds an extra 12KB to repository

• Found files with invalid states:

  • SimG4Core/Notification/go.1:
    • Added: 4d7cd73
    • Deleted: d5d5ee0

[cmsbuild]

Pull request #33202 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

[davidlange6]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-349639/13585/summary.html
COMMIT: d5d5ee0
CMSSW: CMSSW_11_3_X_2021-03-17-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33202/13585/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2639935
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2639912
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1