code for grooming value maps and pileup jet ID

[jstupak]

Replacement for #2820.

Addition of code for grooming value maps and pileup jet ID. This code is part of the "jet toolbox."

[slava77]

I see that the weight files are gzipped in the release:
e.g. /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc6_amd64_gcc481/cms/cmssw-patch/CMSSW_7_1_X_2014-04-12-1400/external/slc6_amd64_gcc481/data/RecoJets/JetProducers/data/TMVAClassificationCategory_JetID_MET_53X_Dec2012.weights.xml.gz

You will need to use the same in the configs as well.
The tmva file reader will unzip gzipped files on the fly
(the comment applies to all other gzipped files)

[slava77]

-1

tested in CMSSW_7_1_X_2014-04-12-1400
in

runTheMatrix.py -l 38.0 --useInput all --command="-n 1000"

Begin processing the 356th record. Run 1, Event 9556, LumiSection 96 at 14-Apr-2014 04:54:31.852 CEST
----- Begin Fatal Exception 14-Apr-2014 04:54:33 CEST-----------------------
An exception of category 'InvalidReference' occurred while
   [0] Processing run: 1 lumi: 96 event: 9556
   [1] Running path 'reconstruction_step'
   [2] Calling event method for module RecoJetDeltaRValueMapProducer/'ca8PFJetsCHSPrunedLinks'
Exception Message:
ValueMap::Filler: handle and reference collections should the same size

[cmsbuild]

A new Pull Request was created by @jstupak for CMSSW_7_1_X.

code for grooming value maps and pileup jet ID

It involves the following packages:

CommonTools/RecoAlgos
RecoJets/Configuration
RecoJets/JetProducers

@cmsbuild, @Degano, @nclopezo can you please review it and eventually sign? Thanks.
@yslai, @TaiSakuma, @nhanvtran this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[slava77]

@cmsbuild Giulio, why does the bot announcement message not contain reco L2 names?

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3321/890/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3321/890/summary.html

[ktf]

Because you rejected it before the message was sent, so it assumes you are aware of it and does not bother you… Yes, it's that smart… ;)

[jstupak]

The latest commit remedies the issue pointed out by @slava77

[cmsbuild]

Pull request #3321 was updated. @nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please check and sign again.

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3321/911/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3321/911/summary.html

[slava77]

+1

for #3321 02ed45a

tested in CMSSW_7_1_X_2014-04-14-0200 (test area sign344)
the new module ca8PFJetsCHSPrunedLinks takes very little time (0.1 ms/evt); the new product floatedmValueMap_ca8PFJetsCHSPrunedLinks appears in RECO and AOD as expected (the size is ~90 bytes/event compressed)

no changes to monitored RECO quantities

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

[ktf]

This breaks macosx builds because it contains two files with identical names but different capitalisation. I'll rename JetIdParams_cfi.py to JetIDParams_cfi.py in a new pull request.

[jstupak]

Actually JetIDParams_cfi.py and JetIdParams_cfi.py are not related to one another, and we should not overwrite the former with the latter. I did not notice this naming conflict when I ported the latter from UserCode to cmssw.

I think what should be done is to rename the new JetIdParams_cfi.py to puJetIdParams_cfi.py, and update puJetIDAlgo_cff.py accordingly:

replace:
from RecoJets.JetProducers.JetIdParams_cfi import *
with:
from RecoJets.JetProducers.puJetIdParams_cfi import *

[ktf]

Ok, I think I fixed it in #3458.