Add support for configuration validation to EDLooper #33213
Conversation
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33213/21648
|
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages: FWCore/Framework @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild, please test |
|
@Dr15Jones please review |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-124116/13594/summary.html Comparison SummarySummary:
|
|
|
||
| const std::string& baseType() const override { return kBaseForEDLooper; } | ||
|
|
||
| const std::string& extendedBaseType() const override { return kEmpty; } |
There was a problem hiding this comment.
These could have all been marked final. Not work the change though.
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
+1 |
PR description:
While working on something else, I noticed that configuration validation is not used for EDLoopers. This PR adds that support.
Resolves cms-sw/framework-team#82
PR validation:
Framework unit tests run. Test with EDLooper using the functionality (not included in this PR though, will come later) can generate a
cfifile, and configuration parameters specified infillDescriptions()but absent in python configuration are being automatically added before the constructor.