Phase2-hgx279 Next step for V15 geometry for HGCal

[bsunanda]

PR description:

Next step for V15 geometry for HGCal (can load the parameters)

PR validation:

Use the runTheMatrix test workflows to test this

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33248/21708

• This PR adds an extra 124KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Geometry/HGCalCommonData/src/HGCalDDDConstants.cc modified in PR(s): Heterogeneous HGCAL RecHit Calibration #32683

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33248/21708/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33248/21708/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33248/21709

• This PR adds an extra 128KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Geometry/HGCalCommonData/src/HGCalDDDConstants.cc modified in PR(s): Heterogeneous HGCAL RecHit Calibration #32683

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

Geometry/CaloTopology
Geometry/HGCalCommonData
Geometry/HGCalSimData

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @srimanob, @kpedro88 can you please review it and eventually sign? Thanks.
@fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33248/21710

• This PR adds an extra 128KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Geometry/HGCalCommonData/src/HGCalDDDConstants.cc modified in PR(s): Heterogeneous HGCAL RecHit Calibration #32683

[cmsbuild]

Pull request #33248 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @srimanob, @kpedro88 can you please check and sign again.

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3efc48/13684/summary.html
COMMIT: 78e26a9
CMSSW: CMSSW_11_3_X_2021-03-22-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33248/13684/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2639935
• DQMHistoTests: Total failures: 12
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2639900
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[cvuosalo]

+1

[bsunanda]

@srimanob @kpedro88 Please approve this. Waiting for its integration to move to next step

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1