Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove LumiProducer from RecoTLR #33256

Merged
merged 1 commit into from Mar 24, 2021
Merged

Conversation

jpata
Copy link
Contributor

@jpata jpata commented Mar 24, 2021

PR description:

As pointed out in #25090 (comment), the outdated LumiProducer that prevents concurrent lumi processing was not completely disabled in #33024. I removed it now also from the RecoTLR config, and a grep does not reveal any other reco sequences where lumiProducer_cff is used.

PR validation:

The workflow 1000.0 no longer runs the LumiProducer.

FYI @gkrintir @makortel

@jpata
Copy link
Contributor Author

jpata commented Mar 24, 2021

assign reconstruction

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33256/21733

  • This PR adds an extra 12KB to repository

@jpata
Copy link
Contributor Author

jpata commented Mar 24, 2021

@cmsbuild please test

@cmsbuild
Copy link
Contributor

New categories assigned: reconstruction

@slava77,@perrotta,@jpata you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jpata (Joosep Pata) for master.

It involves the following packages:

Configuration/DataProcessing

@perrotta, @silviodonato, @franzoni, @slava77, @jpata, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f7d0d3/13729/summary.html
COMMIT: 5d97531
CMSSW: CMSSW_11_3_X_2021-03-23-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33256/13729/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 30 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2639935
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 2
  • DQMHistoTests: Total successes: 2639905
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 1000.0 ): -0.004 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 1000.0 ): -0.004 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 155 log files, 37 edm output root files, 37 DQM output files
  • TriggerResults: no differences found

@jpata
Copy link
Contributor Author

jpata commented Mar 24, 2021

+reconstruction

@silviodonato
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 6399684 into cms-sw:master Mar 24, 2021
@jpata jpata deleted the lumiprod_recotlr branch September 16, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants