New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean BuildFiles and add source_only flags to fix warnings #33282
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33282/21787
|
A new Pull Request was created by @guitargeek (Jonas Rembser) for master. It involves the following packages: CondCore/SiPixelPlugins @andrius-k, @ggovi, @ianna, @kpedro88, @Martin-Grunewald, @rekovic, @santocch, @cecilecaillol, @perrotta, @civanch, @makortel, @ErnestaP, @ahmad3213, @cmsbuild, @fwyzard, @Dr15Jones, @cvuosalo, @mdhildreth, @jfernan2, @slava77, @jpata, @kmaeshima, @srimanob, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
@@ -1,4 +1,4 @@ | |||
<use name="CommonTools/TrackerMap"/> | |||
<use name="CommonTools/TrackerMap"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why add trailing space?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excuse me, that was a mistake. Should I fix it now or do you first want to run the tests? Or maybe abort?
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33282/21788
|
+1 |
+1 |
+1 |
+Upgrade |
+l1 |
+heterogeneous |
merge |
+1 |
PR description:
Another quick BuildFile cleaning PR in the style of many before (for example #33143).
This PR cleans unnecessary includes from CMSSW BuildFiles that were recently added.
More importantly, it also adds the
source_only="1"
flag when there are dependencies on source-only packages that have no BuildFiles themselves. Otherwise, we get a warning withscram b
. This was already done in #33143, but in the meantime a few new<use name="DataFormats/MuonData"/>
were introduced in CMSSW that needed to be fixed.PR validation:
CMSSW compiles.
if this PR is a backport please specify the original PR and why you need to backport that PR:
No backport intended.