Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean BuildFiles and add source_only flags to fix warnings #33282

Merged
merged 1 commit into from Apr 2, 2021
Merged

Clean BuildFiles and add source_only flags to fix warnings #33282

merged 1 commit into from Apr 2, 2021

Conversation

guitargeek
Copy link
Contributor

PR description:

Another quick BuildFile cleaning PR in the style of many before (for example #33143).

This PR cleans unnecessary includes from CMSSW BuildFiles that were recently added.

More importantly, it also adds the source_only="1" flag when there are dependencies on source-only packages that have no BuildFiles themselves. Otherwise, we get a warning with scram b. This was already done in #33143, but in the meantime a few new <use name="DataFormats/MuonData"/> were introduced in CMSSW that needed to be fixed.

PR validation:

CMSSW compiles.

if this PR is a backport please specify the original PR and why you need to backport that PR:

No backport intended.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33282/21787

  • This PR adds an extra 40KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

CondCore/SiPixelPlugins
CondCore/SiStripPlugins
DataFormats/CSCDigi
DataFormats/GEMDigi
DataFormats/RPCDigi
Geometry/MTDGeometryBuilder
HLTrigger/Egamma
HLTrigger/HLTcore
HeterogeneousCore/SonicTriton
L1Trigger/L1TNtuples
PhysicsTools/JetExamples
PhysicsTools/JetMCAlgos
PhysicsTools/PatAlgos
RecoEgamma/PhotonIdentification
RecoHGCal/TICL
RecoTracker/FinalTrackSelectors
RecoVertex/PrimaryVertexProducer
Validation/CSCRecHits

@andrius-k, @ggovi, @ianna, @kpedro88, @Martin-Grunewald, @rekovic, @santocch, @cecilecaillol, @perrotta, @civanch, @makortel, @ErnestaP, @ahmad3213, @cmsbuild, @fwyzard, @Dr15Jones, @cvuosalo, @mdhildreth, @jfernan2, @slava77, @jpata, @kmaeshima, @srimanob, @rvenditti can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @felicepantaleo, @jainshilpi, @hatakeyamak, @emilbols, @kpedro88, @jshlee, @OzAmram, @thomreis, @mbluj, @lgray, @varuns23, @seemasharmafnal, @JyothsnaKomaragiri, @mmarionncern, @kreczko, @jdolen, @makortel, @JanFSchulte, @watson-ij, @dgulhan, @apsallid, @dkotlins, @dildick, @ferencek, @Sam-Harper, @GiacomoSguazzoni, @rovere, @VinInn, @jdamgov, @dinyar, @nhanvtran, @gkasieczka, @schoef, @ebrondol, @ptcox, @mtosi, @fabiocos, @clelange, @Martin-Grunewald, @riga, @swozniewski, @ahinzmann, @sobhatta, @lecriste, @afiqaize, @gpetruc, @mariadalfonso, @tvami, @mmusich, @andrzejnovak, @ram1123 this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor

@cmsbuild, please test

@@ -1,4 +1,4 @@
<use name="CommonTools/TrackerMap"/>
<use name="CommonTools/TrackerMap"/>
Copy link
Contributor

@makortel makortel Mar 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why add trailing space?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excuse me, that was a mistake. Should I fix it now or do you first want to run the tests? Or maybe abort?

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33282/21788

  • This PR adds an extra 40KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@jfernan2
Copy link
Contributor

+1

@civanch
Copy link
Contributor

civanch commented Mar 30, 2021

+1

@Martin-Grunewald
Copy link
Contributor

+1

@srimanob
Copy link
Contributor

+Upgrade

@cecilecaillol
Copy link
Contributor

+l1

@guitargeek
Copy link
Contributor Author

Hi @makortel, @ggovi, and @santocch, could you please sign this PR if you okay with it? Thanks!

@fwyzard
Copy link
Contributor

fwyzard commented Apr 1, 2021

+heterogeneous

@silviodonato
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit c4fa241 into cms-sw:master Apr 2, 2021
@guitargeek guitargeek deleted the deps_1 branch April 2, 2021 09:09
@santocch
Copy link

santocch commented Apr 5, 2021

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment