[HGCAL] CaloParticleSelector selects non-converted CP

[ebrondol]

PR description:

This PR correctly identify the CaloParticle which have converted in the Tracker using the getPositionAtBoundary and getMomentumAtBoundary methods from the SimTrack associated. Before this was done looking at the number of SimClusters associated, but this method was not fully correct: in the specific case of the single photons, they always had 2 SimClusters because of pair production but not always was in the Tracker.
An exception is introduced for the electrons which most of the time undergo bremsstrahlung and therefore are always converting in the Tracker.

It would be great if this PR manage to get into 11_3_0.

PR validation:

• Efficiency on single photons before the PR:
  
• Efficiency on single photons after the PR:
  

@apsallid @lecriste @rovere @felicepantaleo

[rovere]

@cmsbuild please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33309/21839

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Validation/HGCalValidation/plugins/HGCalValidator.cc modified in PR(s): MultiCluster-CaloParticle associator #32941

[cmsbuild]

A new Pull Request was created by @ebrondol (Erica Brondolin) for master.

It involves the following packages:

Validation/HGCalValidation

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@vandreev11, @sethzenz, @bsunanda, @rovere, @lgray, @cseez, @apsallid, @pfs, @lecriste, @hatakeyamak this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0a6364/13872/summary.html
COMMIT: 60b0b66
CMSSW: CMSSW_11_3_X_2021-03-30-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33309/13872/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS Clang-Tidy warnings: There are 1 Clang-Tidy warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0a6364/13872/llvm-analysis/cmsclangtidy.txt for details.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2640841
• DQMHistoTests: Total failures: 4943
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2635876
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[jfernan2]

@ebrondol apart from the clang-tidy warnings, the PR is introducing a lot of changes in HGCAL folder for phase2 samples, could you please have a look and see if there are not any unexpected changes?
Thanks

[ebrondol]

Hi @jfernan2 , unfortunately when I access the link to the GUI I have '500 Internal Server Error'. It have double checked and it seems it's not a problem from my side. Could you please let me know when the link/the GUI is fixed?

[jfernan2]

do this link work for you?
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_11_3_X_2021-03-30-2300+0a6364/41973/dqm-histo-comparison-summary.html
Down there you have all the differences for every wf tested

[ebrondol]

I can access but some of the folders are not clickable in HGCAL/HGCalValidator/ such as ticlMultiClustersFromTrackstersMerge. I can only see the ones that end with EM, HAD and Trk.

[jfernan2]

I can see all plots, e.g.
https://tinyurl.com/ydl5or4m
Can you clarify what you mean by not clickable?
Since the folder names are very large, you should select size=large in the top left menu of the GUI

[ebrondol]

We are currently running further test. We will update the PR shortly.

[ebrondol]

@jfernan2
@apsallid and I checked the differences and we can confirmed that they are all expected.

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1

[qliphy]

+1