[DD4hep] Set material temperature and pressure to NTP instead of default STP

[cvuosalo]

When the geometry is being built, the materials used in the geometry are also constructed. Previously, with DD4hep, no temperature or pressure was specified for the materials, so they gained the defaults from ROOT, which are STP, Standard Temperature and Pressure, 273.15 K and 1 atm. However, with DDD the material temperatures are 293.15, which corresponds to NTP, Normal Temperature and Pressure.

This PR sets the DD4hep conditions to NTP, and then uses those values to set the material temperatures and pressures.

PR validation:

The test script SimG4Core/PrintGeomInfo/test/python/g4OverlapCheck_dd4hep_cfg.py shows that the material temperatures with this PR are now 293.15 K.

No backport.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33344/21921

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @cvuosalo (Carl Vuosalo) for master.

It involves the following packages:

DetectorDescription/DDCMS

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@fabiocos, @slomeo, @vargasa this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cvuosalo]

@cmsbuild please test workflow 11634.911, 11650.911

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e55d42/14028/summary.html
COMMIT: abce3e4
CMSSW: CMSSW_11_3_X_2021-04-06-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33344/14028/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-e55d42/11650.911_ZMM_14+2021_DD4hep+ZMM_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST+ALCA

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2640868
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2640845
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[cvuosalo]

@ghugo83 Any comments on this PR?

[ghugo83]

@ghugo83 Any comments on this PR?

No that's great, temperature in G4 materials matches DDD now!

[cvuosalo]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1