Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessors for CLCT and LCT BX as defined in RAW data [11_2_X] #33357

Merged
merged 1 commit into from Apr 9, 2021
Merged

Accessors for CLCT and LCT BX as defined in RAW data [11_2_X] #33357

merged 1 commit into from Apr 9, 2021

Conversation

dildick
Copy link
Contributor

@dildick dildick commented Apr 7, 2021

PR description:

Get 2-bit CLCT BX and 1-bit LCT BX as defined in RAW data. Needed for data vs emulator studies in Run-3 L1T DQM. Same numbers as defined in CSCTMBHeader2013::bits::clct_bxn and CSCTMBHeader2013::bits::MPC_Muon0_bx_.

PR validation:

Code compiles.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #33335

Before submitting your pull requests, make sure you followed this checklist:

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2021

A new Pull Request was created by @dildick (Sven Dildick) for CMSSW_11_2_X.

It involves the following packages:

DataFormats/CSCDigi

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@ptcox, @rovere this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor

civanch commented Apr 8, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1d354b/14089/summary.html
COMMIT: f719820
CMSSW: CMSSW_11_2_X_2021-04-07-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33357/14089/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2537235
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2537206
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 35 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 151 log files, 37 edm output root files, 36 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented Apr 8, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2021

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 2dc8621 into cms-sw:CMSSW_11_2_X Apr 9, 2021
@dildick dildick deleted the from-CMSSW_11_2_X_2021-04-06-2300-CSC-BX-data-v2 branch April 12, 2021 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants