UL2016 Scale and smearing corrections (backport to 106X) #33359

jainshilpi · 2021-04-07T12:59:44Z

PR description:

This PR is essentially a backport of #33030 and adds UL 2016 scale and smearing corrections in miniAOD in 106X.
Backport concerning nanoAOD will be done in a separate PR.

Changes are done only to RecoEgamma/EgammaTools/python/calibratedEgammas_cff.py

@mariadalfonso @sroychow

cmsbuild · 2021-04-07T13:00:10Z

A new Pull Request was created by @jainshilpi for CMSSW_10_6_X.

It involves the following packages:

RecoEgamma/EgammaTools

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@Sam-Harper, @lgray, @sobhatta, @afiqaize, @varuns23, @ram1123 this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

mariadalfonso · 2021-04-07T14:33:49Z

@jainshilpi
this mini change should go for the b-parking reMINI only as the run2_miniAOD_UL is bounded to the existing pp ongoing production

cmsbuild · 2021-04-07T19:19:51Z

Pull request #33359 was updated. @perrotta, @jpata, @cmsbuild, @slava77 can you please check and sign again.

slava77 · 2021-04-07T19:41:12Z

RecoEgamma/EgammaTools/python/calibratedEgammas_cff.py

@@ -14,6 +16,11 @@
                                   )
 from Configuration.ProcessModifiers.run2_miniAOD_UL_cff import run2_miniAOD_UL

+from Configuration.Eras.Modifier_run2_egamma_2016_cff import run2_egamma_2016
+from Configuration.Eras.Modifier_tracker_apv_vfp30_2016_cff import tracker_apv_vfp30_2016
+(run2_egamma_2016 & tracker_apv_vfp30_2016).toModify(calibratedEgammaSettings,correctionFile = _correctionFile2016ULpreVFP)


this will still get applied with run2_miniAOD_UL and without it.
I think that an applicable requirement here is run2_miniAOD_devel

Suggested change

(run2_egamma_2016 & tracker_apv_vfp30_2016).toModify(calibratedEgammaSettings,correctionFile = _correctionFile2016ULpreVFP)

(run2_miniAOD_devel & run2_egamma_2016 & tracker_apv_vfp30_2016).toModify(calibratedEgammaSettings,correctionFile = _correctionFile2016ULpreVFP)

okay then I will change this in both the 2016 UL modifiers

@slava77
for my own understanding the bParking will inherit all we had in the run2_miniAOD_devel or run2_miniAOD_UL

bParking does not apply to 2016.
If this was for 2018, then we'd use (run2_miniAOD_devel | bParking)

missed to include the cff file - sorry about it - done now

cmsbuild · 2021-04-07T19:50:34Z

Pull request #33359 was updated. @perrotta, @jpata, @cmsbuild, @slava77 can you please check and sign again.

slava77 · 2021-04-07T20:01:04Z

@cmsbuild please test workflow 136.72411,136.76111,136.77211,136.83111,136.88811,1325.516,1325.5161,1325.517,1325.518

cmsbuild · 2021-04-07T21:04:48Z

-1

Failed Tests: UnitTests RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a86311/14079/summary.html
COMMIT: cfbcadd
CMSSW: CMSSW_10_6_X_2021-04-07-1100/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33359/14079/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test runtestPhysicsToolsNanoAOD had ERRORS

RelVals

136.7611136.7611_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM/step2_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM.log
136.72411136.72411_RunJetHT2016B_reminiaodUL+RunJetHT2016B_reminiaodUL+REMINIAOD_data2016UL_HIPM+HARVESTDR2_REMINIAOD_data2016UL_HIPM/step2_RunJetHT2016B_reminiaodUL+RunJetHT2016B_reminiaodUL+REMINIAOD_data2016UL_HIPM+HARVESTDR2_REMINIAOD_data2016UL_HIPM.log
136.76111136.76111_RunJetHT2016E_reminiaodUL+RunJetHT2016E_reminiaodUL+REMINIAOD_data2016UL_HIPM+HARVESTDR2_REMINIAOD_data2016UL_HIPM/step2_RunJetHT2016E_reminiaodUL+RunJetHT2016E_reminiaodUL+REMINIAOD_data2016UL_HIPM+HARVESTDR2_REMINIAOD_data2016UL_HIPM.log

Expand to see more relval errors ...

RelVals-INPUT

4.64.6_MinimumBias2010A+MinimumBias2010A+RECOSKIMALCA+HARVESTDR1/step2_MinimumBias2010A+MinimumBias2010A+RECOSKIMALCA+HARVESTDR1.log
136.72411136.72411_RunJetHT2016B_reminiaodUL+RunJetHT2016B_reminiaodUL+REMINIAOD_data2016UL_HIPM+HARVESTDR2_REMINIAOD_data2016UL_HIPM/step2_RunJetHT2016B_reminiaodUL+RunJetHT2016B_reminiaodUL+REMINIAOD_data2016UL_HIPM+HARVESTDR2_REMINIAOD_data2016UL_HIPM.log
136.76111136.76111_RunJetHT2016E_reminiaodUL+RunJetHT2016E_reminiaodUL+REMINIAOD_data2016UL_HIPM+HARVESTDR2_REMINIAOD_data2016UL_HIPM/step2_RunJetHT2016E_reminiaodUL+RunJetHT2016E_reminiaodUL+REMINIAOD_data2016UL_HIPM+HARVESTDR2_REMINIAOD_data2016UL_HIPM.log

Expand to see more relval errors ...

sroychow · 2021-04-07T21:11:33Z

RecoEgamma/EgammaTools/python/calibratedEgammas_cff.py

@@ -1,9 +1,11 @@
 import FWCore.ParameterSet.Config as cms



@jainshilpi you need to add
from Configuration.Eras.Modifier_run2_miniAOD_devel_cff import run2_miniAOD_devel

cmsbuild · 2021-04-07T21:12:06Z

Pull request #33359 was updated. @perrotta, @jpata, @cmsbuild, @slava77 can you please check and sign again.

slava77 · 2021-04-07T22:27:13Z

@cmsbuild please test workflow 136.72411,136.76111,136.77211,136.83111,136.88811,1325.516,1325.5161,1325.517,1325.518

cmsbuild · 2021-04-08T01:50:05Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a86311/14080/summary.html
COMMIT: 4ddfc2b
CMSSW: CMSSW_10_6_X_2021-04-07-1100/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33359/14080/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-a86311/136.72411_RunJetHT2016B_reminiaodUL+RunJetHT2016B_reminiaodUL+REMINIAOD_data2016UL_HIPM+HARVESTDR2_REMINIAOD_data2016UL_HIPM

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 3215541
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3215205
DQMHistoTests: Total skipped: 334
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 143 log files, 29 edm output root files, 35 DQM output files
TriggerResults: no differences found

slava77 · 2021-04-08T16:53:46Z

+reconstruction

for #33359 4ddfc2b

code changes are in line with the PR description and the follow up review
- this is a partial backport of EGamma: systematics + UL2016 scale and smearing corrections #33030, covering the update in miniAOD/reco, disabled by default with run2_miniAOD_devel to satisfy the no-change requirement
jenkins tests pass and comparisons with the baseline show no (relevant) differences

cms-sw/cmsdist#6800 is needed with this PR (async merge is OK)

cmsbuild · 2021-04-08T16:54:05Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2021-04-09T06:55:21Z

+1

UL2016 Scale and smearing corrections for the backport

3c98c13

cmsbuild added this to the CMSSW_10_6_X milestone Apr 7, 2021

cmsbuild added orp-pending pending-signatures reconstruction-pending tests-pending labels Apr 7, 2021

removing run2_miniAOD_UL from the UL2016 modifier

8da22cb

slava77 reviewed Apr 7, 2021

View reviewed changes

correctly implementing for UL2016

cfbcadd

cmsbuild added tests-started and removed tests-pending labels Apr 7, 2021

cmsbuild added tests-rejected and removed tests-started labels Apr 7, 2021

adding the cff for the new modifier

4ddfc2b

sroychow reviewed Apr 7, 2021

View reviewed changes

cmsbuild added tests-pending and removed tests-rejected labels Apr 7, 2021

cmsbuild added tests-started and removed tests-pending labels Apr 7, 2021

cmsbuild added tests-approved and removed tests-started labels Apr 8, 2021

slava77 mentioned this pull request Apr 8, 2021

[10.6] update EgammaAnalysis-ElectronTools to V00-03-01 cms-sw/cmsdist#6800

Merged

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels Apr 8, 2021

cmsbuild added orp-approved and removed orp-pending labels Apr 9, 2021

cmsbuild merged commit 769dffb into cms-sw:CMSSW_10_6_X Apr 9, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

UL2016 Scale and smearing corrections (backport to 106X) #33359

UL2016 Scale and smearing corrections (backport to 106X) #33359

jainshilpi commented Apr 7, 2021

cmsbuild commented Apr 7, 2021

mariadalfonso commented Apr 7, 2021 •

edited

cmsbuild commented Apr 7, 2021

slava77 Apr 7, 2021

jainshilpi Apr 7, 2021

mariadalfonso Apr 7, 2021

slava77 Apr 7, 2021

jainshilpi Apr 7, 2021

cmsbuild commented Apr 7, 2021

slava77 commented Apr 7, 2021

cmsbuild commented Apr 7, 2021

sroychow Apr 7, 2021

cmsbuild commented Apr 7, 2021

slava77 commented Apr 7, 2021

cmsbuild commented Apr 8, 2021

slava77 commented Apr 8, 2021

cmsbuild commented Apr 8, 2021

silviodonato commented Apr 9, 2021

	(run2_egamma_2016 & tracker_apv_vfp30_2016).toModify(calibratedEgammaSettings,correctionFile = _correctionFile2016ULpreVFP)
	(run2_miniAOD_devel & run2_egamma_2016 & tracker_apv_vfp30_2016).toModify(calibratedEgammaSettings,correctionFile = _correctionFile2016ULpreVFP)

UL2016 Scale and smearing corrections (backport to 106X) #33359

UL2016 Scale and smearing corrections (backport to 106X) #33359

Conversation

jainshilpi commented Apr 7, 2021

PR description:

cmsbuild commented Apr 7, 2021

mariadalfonso commented Apr 7, 2021 • edited

cmsbuild commented Apr 7, 2021

slava77 Apr 7, 2021

Choose a reason for hiding this comment

jainshilpi Apr 7, 2021

Choose a reason for hiding this comment

mariadalfonso Apr 7, 2021

Choose a reason for hiding this comment

slava77 Apr 7, 2021

Choose a reason for hiding this comment

jainshilpi Apr 7, 2021

Choose a reason for hiding this comment

cmsbuild commented Apr 7, 2021

slava77 commented Apr 7, 2021

cmsbuild commented Apr 7, 2021

Unit Tests

RelVals

RelVals-INPUT

sroychow Apr 7, 2021

Choose a reason for hiding this comment

cmsbuild commented Apr 7, 2021

slava77 commented Apr 7, 2021

cmsbuild commented Apr 8, 2021

Comparison Summary

slava77 commented Apr 8, 2021

cmsbuild commented Apr 8, 2021

silviodonato commented Apr 9, 2021

mariadalfonso commented Apr 7, 2021 •

edited