Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2-hgx281 Compare DDD against DD4Hep scenario for 2026D76 scenario #33379

Merged
merged 2 commits into from Apr 11, 2021

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Apr 8, 2021

PR description:

Compare DDD against DD4Hep scenario for 2026D76 scenario. Used in testing the geometry through detailed printouts

PR validation:

Compared the workflow 34634 with DDD and DD4Hep

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2021

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33379/21969

  • This PR adds an extra 36KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33379/21970

  • This PR adds an extra 40KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2021

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

Geometry/HGCalCommonData

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @srimanob, @kpedro88 can you please review it and eventually sign? Thanks.
@fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

bsunanda commented Apr 9, 2021

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1a982b/14147/summary.html
COMMIT: 36c916f
CMSSW: CMSSW_11_3_X_2021-04-09-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33379/14147/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2865506
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2865477
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 37 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@cvuosalo
Copy link
Contributor

cvuosalo commented Apr 9, 2021

+1

@srimanob
Copy link
Contributor

Hi @bsunanda
I'm not sure I understand the PR title and description. Is it to add a test, or something else? Thanks.

@bsunanda
Copy link
Contributor Author

@srimanob We have been struggling to find the reason of failure of Phase2 scenario in dd4hep. We use different codes for the algorithms and the main purpose of this PR is to see if the 2 sets of algorithms used for V14 HGCal give the same results. There are debug statements which are made similar outputs. Running the codes separately for silicon cells, wafers, full silicon layers, mixed layers and comparing the two sets of outputs using diff show identical results from ddd and dd4hep. This required changes in the debug statements, defining a few cdi's, cfg's which are parts of this PR

@srimanob
Copy link
Contributor

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Apr 11, 2021

+1

@cmsbuild cmsbuild merged commit 887ebbf into cms-sw:master Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants