All daughter decay filter

[ats2008]

PR description:

This PR intends to add new GEN filter to the repo that will select a specific decay based on the decaying particle its daughters and kinematic constraints put on the daughters.This intended as a new module to remove some of the shortcomings that the existing filter has.

The PythiaDauVFilter as implemented here , does not check for the compliance of the cuts for each particle separately. For the specified mother (ParticleID) it checks if there are at least NumberDaughters daughter particles and exactly NumberDaughters daughters that satisfies the specific eta & pt cuts. ( the gamma multiplicity of Bs->Mu Mu Gamma decay in the validation section)

For detailed context on the issue please see the slides from the BPH Trigger meeting here( tldr : see slides 6,7,8 )

PR validation:

The validation was done by using the deacy Bs->Mu+ Mu- Gamma, using PythiaDauVFilter and the PythiaAllDauVFilter

With PythiaDauVFilter filter

For PythiaAllDauVFilter filter

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33408/22038

• This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-checks:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33408/22038/code-checks.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33408/22038/code-checks.patch | patch -p1
  You can also run scram build code-checks to apply code checks directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33408/22039

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @ats2008 (Aravind Sugunan) for master.

It involves the following packages:

GeneratorInterface/GenFilters

@SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[SiewYan]

please test

[cmsbuild]

-1

Failed Tests: ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-904a3d/14179/summary.html
COMMIT: 4f0cfa3
CMSSW: CMSSW_11_3_X_2021-04-11-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33408/14179/install.sh to create a dev area with all the needed externals and cmssw changes.

Clang Build

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33408/22049

• This PR adds an extra 20KB to repository

[cmsbuild]

Pull request #33408 was updated. @SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please check and sign again.

[SiewYan]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-904a3d/14188/summary.html
COMMIT: b00d9f0
CMSSW: CMSSW_11_3_X_2021-04-12-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33408/14188/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2865526
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2865503
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[SiewYan]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1