Remove deprecated usages of isnan or isinf

[perrotta]

PR description:

According to the static analyzer, as of CMSSW_11_3_X_2021-04-12-2300 only 7 occurrencies of the deprecated isnan() or isinf() calls remained in CMSSW

This PR finally gets rid of all them

PR validation:

It builds

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33418/22067

• This PR adds an extra 32KB to repository

[cmsbuild]

A new Pull Request was created by @perrotta for master.

It involves the following packages:

CalibCalorimetry/HcalAlgos
DQMOffline/Muon
FastSimulation/CTPPSFastTrackingProducer
RecoBTag/FeatureTools
RecoParticleFlow/PFProducer
RecoTracker/SpecialSeedGenerators

@perrotta, @malbouis, @ssekmen, @yuanchao, @lveldere, @kmaeshima, @civanch, @sbein, @christopheralanwest, @andrius-k, @mdhildreth, @ErnestaP, @cmsbuild, @jfernan2, @tlampen, @ahmad3213, @slava77, @jpata, @pohsun, @rvenditti, @francescobrivio can you please review it and eventually sign? Thanks.
@emilbols, @mariadalfonso, @abbiendi, @mmusich, @seemasharmafnal, @mmarionncern, @calderona, @makortel, @abdoulline, @JanFSchulte, @jhgoh, @lgray, @sscruz, @cericeci, @hqucms, @felicepantaleo, @ferencek, @trocino, @rociovilar, @barvic, @GiacomoSguazzoni, @rovere, @VinInn, @bellan, @tocheng, @hatakeyamak, @ebrondol, @ptcox, @mtosi, @dgulhan, @HuguesBrun, @Fedespring, @JyothsnaKomaragiri, @cbernet, @gpetruc, @matt-komm, @andrzejnovak this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b906f/14205/summary.html
COMMIT: d1f648f
CMSSW: CMSSW_11_3_X_2021-04-12-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33418/14205/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS Clang-Tidy warnings: There are Clang-Tidy warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b906f/14205/llvm-analysis/cmsclangtidy.txt for details.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2865526
• DQMHistoTests: Total failures: 12
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2865491
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 37 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33418/22078

• This PR adds an extra 32KB to repository

[cmsbuild]

Pull request #33418 was updated. @perrotta, @malbouis, @ssekmen, @yuanchao, @lveldere, @kmaeshima, @civanch, @sbein, @christopheralanwest, @andrius-k, @mdhildreth, @ErnestaP, @cmsbuild, @jfernan2, @tlampen, @ahmad3213, @slava77, @jpata, @pohsun, @rvenditti, @francescobrivio can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b906f/14227/summary.html
COMMIT: df7e292
CMSSW: CMSSW_11_3_X_2021-04-13-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33418/14227/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS Clang-Tidy warnings: There are Clang-Tidy warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b906f/14227/llvm-analysis/cmsclangtidy.txt for details.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2864426
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2864397
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 37 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[perrotta]

+1

• Technical
• Jenkins tests pass

[jfernan2]

+1

[yuanchao]

+1

• remove deprecated isnan() or isinf() calls
• WF matrix tests and unit tests all passed
• build warnings are not part of the modification

[perrotta]

@cms-sw/fastsim-l2 could you please check and sign, if you think so?

[sandrofonseca]

@perrotta I have not involved in the PPS project anymore. I think that @mundim can help you with it.

[mundim]

Could you please confirm that the approximation sin(theta) == theta was really wanted?
Yes, since in this case, theta is the order of µrad, this approximation is pretty much valid.

thanks.

[silviodonato]

kind reminder @cms-sw/fastsim-l2

[civanch]

+1

modifications are technical. PPS part of modifications are correct.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1