Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore missing GEM geometry #3343

Merged
merged 1 commit into from Apr 16, 2014
Merged

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Apr 15, 2014

  • Dump GEM geometry only if it is there

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ianna for CMSSW_7_1_X.

Ignore missing GEM geometry

It involves the following packages:

Fireworks/Geometry

@Dr15Jones, @cmsbuild, @alja, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks.
@alja this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@ktf
Copy link
Contributor

ktf commented Apr 16, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request Apr 16, 2014
Fireworks -- Ignore missing GEM geometry
@ktf ktf merged commit d990761 into cms-sw:CMSSW_7_1_X Apr 16, 2014
@alja
Copy link
Contributor

alja commented Apr 16, 2014

@ianna
Why GEM geometry is missing in 7_1_X?

@ianna
Copy link
Contributor Author

ianna commented Apr 17, 2014

@alja - there is no GEM subdet for Run2. It's going to be built and installed later.

@ianna ianna deleted the gem-geometry-dump branch October 26, 2015 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants