Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate EcalTPCondAnalyzer to use esConsumes #33431

Merged
merged 1 commit into from Apr 16, 2021

Conversation

thomreis
Copy link
Contributor

PR description:

Migrate EcalTPCondAnalyzer to use esConsumes and replace cout statements with LogVerbatim. This should fix a set of static analyzer warnings reported in #33349 tests.
The module has probably not been used since its migration to being a one::EDAnalyzer because it was actually broken and did not print anything. This was fixed by adding edm::one::WatchRuns.

PR validation:

Tested by running SimCalorimetry/EcalTrigPrimProducers/test/readDBTPConds_GlobalTag_cfg.py.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33431/22101

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @thomreis (Thomas Reis) for master.

It involves the following packages:

SimCalorimetry/EcalTrigPrimProducers

@cmsbuild, @rekovic, @cecilecaillol can you please review it and eventually sign? Thanks.
@rchatter, @simonepigazzini, @rovere, @thomreis, @argiro this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cecilecaillol
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e1a1e8/14238/summary.html
COMMIT: 2c6c4f4
CMSSW: CMSSW_11_3_X_2021-04-14-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33431/14238/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2864426
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2864391
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 37 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 8b8cfcd into cms-sw:master Apr 16, 2021
@thomreis thomreis deleted the ecal_tp_esconsumes_migration branch April 21, 2021 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants