New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate EcalTPCondAnalyzer to use esConsumes #33431
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33431/22101
|
A new Pull Request was created by @thomreis (Thomas Reis) for master. It involves the following packages: SimCalorimetry/EcalTrigPrimProducers @cmsbuild, @rekovic, @cecilecaillol can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+l1 |
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e1a1e8/14238/summary.html Comparison SummarySummary:
|
+1 |
PR description:
Migrate EcalTPCondAnalyzer to use esConsumes and replace cout statements with LogVerbatim. This should fix a set of static analyzer warnings reported in #33349 tests.
The module has probably not been used since its migration to being a one::EDAnalyzer because it was actually broken and did not print anything. This was fixed by adding
edm::one::WatchRuns
.PR validation:
Tested by running
SimCalorimetry/EcalTrigPrimProducers/test/readDBTPConds_GlobalTag_cfg.py
.