Data formats for showers in the muon system in Run-3 (HadronicShowerTrigger-4)

[dildick]

PR description:

Data formats for showers in the muon system in Run-3. RegionalMuonShowers are be created from "OR"-ed combinations of CSCShowerDigi in a dedicated sector processor for showers (emulator to follow in a separate pull request). Similarly, MuonShowers are created from "OR"-ed combinations of RegionalMuonShower in a global muon trigger module. From the class definition RegionalMuonShower and MuonShower look like bulky objects, but in the trigger they only carry 4 bits of information per BX. Additional documentation in DN-20-033.

Documentation now also provided in DN-15-017

PR validation:

Code compiles. The new objects are not yet plugged in to the emulators. There should be no difference with respect to the baseline.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

@dinyar

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33446/22131

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

DataFormats/L1TMuon
DataFormats/L1Trigger

@cmsbuild, @rekovic, @cecilecaillol can you please review it and eventually sign? Thanks.
@dinyar, @rovere, @kreczko, @thomreis this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mrodozov]

please test
I'd like to check the new release cycle pr tests

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-95aa24/14262/summary.html
COMMIT: 5f38b62
CMSSW: CMSSW_11_3_X_2021-04-15-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33446/14262/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

• No significant changes to the logs found
• Reco comparison results: 1260 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2864426
• DQMHistoTests: Total failures: 3668
• DQMHistoTests: Total nulls: 19
• DQMHistoTests: Total successes: 2860717
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -45.703 KiB( 37 files compared)
• DQMHistoSizes: changed ( 140.53 ): -44.531 KiB Hcal/DigiRunHarvesting
• DQMHistoSizes: changed ( 140.53 ): -1.172 KiB RPC/DCSInfo
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[dildick]

Nearly all failures coming from 1 WF

[dildick]

@cecilecaillol Let me know if you have questions. I copied the RegionalMuonCand.h and Muon.h objects from the l1t namespace, and adapted a few things to change it to a shower.

[cecilecaillol]

@dildick I see there are still WFs with failed comparisons. Is it understood? Is this PR ready to be merged or are you investigating something?

[dildick]

@dinyar I updated the PR.

[dildick]

@cecilecaillol When you run the tests and the results come back, you may see minor (known) failures coming from the pixel system, from the messagelogger. The large number of failures from that particular workflow is attributed to the DD4HEP geometry which apparently is not entirely reproducible. This is also known - and I've seen it happen in other pull requests.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33446/22191

• This PR adds an extra 20KB to repository

[cmsbuild]

Pull request #33446 was updated. @cmsbuild, @rekovic, @cecilecaillol can you please check and sign again.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33446/22294

• This PR adds an extra 20KB to repository

[cmsbuild]

Pull request #33446 was updated. @cmsbuild, @rekovic, @cecilecaillol can you please check and sign again.

[dildick]

@dinyar I implemented your comments. Please check the new version.

[cecilecaillol]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-95aa24/14607/summary.html
COMMIT: 1bbdbde
CMSSW: CMSSW_12_0_X_2021-04-26-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33446/14607/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2877605
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2877576
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[cecilecaillol]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1