Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HGCAL] TICL SimTracksters - backport 11_3_X #33447

Conversation

felicepantaleo
Copy link
Contributor

PR description:

This is a backport of #33318 to 11_3_X
This PR introduces SimTracksters.
SimTracksters are Tracksters objects containing layerclusters that are associated to the same SimClusters.
They are run in the HGCal Validation Sequence and kept only in FEVT.
They will be useful for benchmarking the pattern recognition as they will produce the best possible tracksters directly from simulation.

PR validation:

used wf 23290.0

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 16, 2021

A new Pull Request was created by @felicepantaleo (Felice Pantaleo) for CMSSW_11_3_X.

It involves the following packages:

DataFormats/HGCalReco
RecoHGCal/Configuration
RecoHGCal/TICL
SimDataFormats/Associations
Validation/Configuration
Validation/HGCalValidation

@perrotta, @andrius-k, @kmaeshima, @civanch, @ErnestaP, @ahmad3213, @cmsbuild, @srimanob, @jfernan2, @mdhildreth, @slava77, @jpata, @kpedro88, @rvenditti can you please review it and eventually sign? Thanks.
@vandreev11, @sethzenz, @bsunanda, @rovere, @lgray, @cseez, @apsallid, @sobhatta, @pfs, @lecriste, @hatakeyamak, @fabiocos, @clelange this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@felicepantaleo
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-80b52b/14265/summary.html
COMMIT: 0e28f7d
CMSSW: CMSSW_11_3_X_2021-04-15-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33447/14265/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2864426
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2864397
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 21731.496 KiB( 37 files compared)
  • DQMHistoSizes: changed ( 23234.0,... ): 5432.873 KiB HGCAL/HGCalValidator
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

+1

@civanch
Copy link
Contributor

civanch commented Apr 16, 2021

+1

@felicepantaleo
Copy link
Contributor Author

@jpata @srimanob a kind reminder. It's exactly the same branch I used in #33318

@perrotta
Copy link
Contributor

backport of #33318

@jpata
Copy link
Contributor

jpata commented Apr 19, 2021

+reconstruction

@srimanob
Copy link
Contributor

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3147875 into cms-sw:CMSSW_11_3_X Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants