MTD geometry and digitization: move check for pixel active area into RectangularMTDTopology, make it usable for BTL as well

[fabiocos]

PR description:

#33340 has cleaned the RectangularMTDTopology and introduced functionalities to take into account non-active areas around pixels. This has been used in the ETL digitization, but it is a general functionality potentially valid fro BTL as well. While in BTL the crystals are correctly positioned at the center of pixels, and there is so far no use of inter-crystal gaps, this PR turns the check for ETL into a general method usable also for BTL if needed.

In order to do this, the mtdParameters.xml values are updated for BTL with values extracted from the ideal geometry, rounding at 1 micron level, and for y moving a residual 0.5 inter-crystal micron to the border gap.

PR validation:

Test wf 34634.0 runs.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33453/22150

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File SimFastTiming/FastTimingCommon/src/ETLDeviceSim.cc modified in PR(s): Migrate most of MixingModule and PreMixingModule to EventSetup consumes #31697

[cmsbuild]

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

Geometry/MTDCommonData
Geometry/MTDGeometryBuilder
SimFastTiming/FastTimingCommon

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @srimanob, @kpedro88 can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[fabiocos]

please test

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-acf605/14287/summary.html
COMMIT: de3e5d1
CMSSW: CMSSW_12_0_X_2021-04-16-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33453/14287/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test GeometryMTDGeometryBuilderTestDriver had ERRORS

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2877046
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2877017
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[fabiocos]

the failure in the MTDGeometryBuilder unit test is due to the change in the parameters, that are part of the monitored quantities in the test. The data reference need to be updated (unfortunately once more)

[fabiocos]

please test with cms-data/Geometry-TestReference#7

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-acf605/14304/summary.html
COMMIT: de3e5d1
CMSSW: CMSSW_12_0_X_2021-04-18-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33453/14304/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2877046
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2877017
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[fabiocos]

@parbol FYI

[cvuosalo]

+1

[civanch]

+1

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

@silviodonato @qliphy @mrodozov please recall to merge this together cms-data/Geometry-TestReference#7 , thanks

[mrodozov]

asap as this is merged i'll get the data external

[qliphy]

+1