Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Geant4 physics sub-libraries for version 10.7 and beyond #33457

Merged
merged 8 commits into from Apr 18, 2021

Conversation

civanch
Copy link
Contributor

@civanch civanch commented Apr 17, 2021

PR description:

This PR include clean-up SimG4Core sub-libraries for Geant4 10.7 and next versions:

  1. removed obsolete classes
  2. improved comments and documentation
  3. reestablish EMN configuration for HGCal
  4. reestablish hadronic configuration for QGSP_FTFP_BERT
  5. should compile against Geant4 11.0
  6. baseline simulation should not be affected

PR validation:

private

if this PR is a backport please specify the original PR and why you need to backport

no backport

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33457/22155

  • This PR adds an extra 212KB to repository

  • Found files with invalid states:

    • SimG4Core/PhysicsLists/src/CMSHyperonFTFPBuilder.cc:
    • SimG4Core/PhysicsLists/interface/CMSHyperonFTFPBuilder.h:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master.

It involves the following packages:

SimG4Core/Application
SimG4Core/CustomPhysics
SimG4Core/GFlash
SimG4Core/PhysicsLists

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @cvuosalo, @rovere, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor Author

civanch commented Apr 17, 2021

please test

@civanch
Copy link
Contributor Author

civanch commented Apr 17, 2021

@bsunanda , this PR introducing new EMN and should make compatible with new Geant4.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4f28d7/14302/summary.html
COMMIT: ffeb93f
CMSSW: CMSSW_12_0_X_2021-04-17-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33457/14302/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2877046
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2877017
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 37 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor Author

civanch commented Apr 17, 2021

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Apr 18, 2021

+1

@cmsbuild cmsbuild merged commit d9d188e into cms-sw:master Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants