Add new workflows to upgradeWorkflowComponents.py for HLT #33461

chayanit · 2021-04-19T06:32:10Z

This is PR to add new upgrade workflows as requested by HLT (STEAM) https://its.cern.ch/jira/browse/PDMVRELVALS-115 and Phase2 L1T https://its.cern.ch/jira/browse/PDMVRELVALS-116. All GEN fragments have been reviewing in #33409 , #33414 , #33433 and #33386. They need for Run3 validation campaign in master release and special request for Phase2 L1T.

Need for 11_3_0 so the backport is needed

Fix indentation in EDAlias python dump

chayanit · 2021-04-19T06:33:54Z

please test

cmsbuild · 2021-04-19T06:39:44Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33461/22158

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): Redesign all GPU workflows to detect if a GPU is present, and fall back to CPU otherwise #33428, Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983, Phase2-gex70 Add a new scenario D84 same as D70 but with updated tracker T24 #33454

cmsbuild · 2021-04-19T06:40:09Z

A new Pull Request was created by @chayanit (Chayanit Asawatangtrakuldee) for master.

It involves the following packages:

Configuration/PyReleaseValidation

@chayanit, @srimanob, @wajidalikhan, @kpedro88, @jordan-martins can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2021-04-19T09:37:08Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b1126/14309/summary.html
COMMIT: 9c46010
CMSSW: CMSSW_12_0_X_2021-04-18-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33461/14309/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Fix indentation in EDAlias python dump #33450 @fwyzard: Fix indentation in EDAlias python dump

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b1126/14309/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b1126/14309/git-merge-result

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 38
DQMHistoTests: Total histograms compared: 2877046
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2877017
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
Checked 160 log files, 37 edm output root files, 38 DQM output files
TriggerResults: no differences found

chayanit · 2021-04-20T08:17:36Z

+1

chayanit · 2021-04-20T08:49:16Z

please test

This PR can be merged only after all GEN fragments are merged or finalised

cmsbuild · 2021-05-03T11:33:08Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33461/22427

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): [DD4hep] start on geometry XML payload producer #33548, Add run3 tracking low pu era #33532, Redesign all GPU workflows to detect if a GPU is present, and fall back to CPU otherwise #33428

cmsbuild · 2021-05-03T11:33:26Z

Pull request #33461 was updated. @jordan-martins, @chayanit, @wajidalikhan, @kpedro88, @cmsbuild, @srimanob can you please check and sign again.

chayanit · 2021-05-03T11:34:49Z

please test

cmsbuild · 2021-05-03T14:23:14Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b1126/14799/summary.html
COMMIT: 41ea0b0
CMSSW: CMSSW_12_0_X_2021-05-03-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33461/14799/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Fix indentation in EDAlias python dump #33450 @fwyzard: Fix indentation in EDAlias python dump

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b1126/14799/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b1126/14799/git-merge-result

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 3 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2662646
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2662617
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 36 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 155 log files, 37 edm output root files, 37 DQM output files
TriggerResults: no differences found

chayanit · 2021-05-04T04:59:15Z

+1

I would need this PR to be merged for final 11_3_0

srimanob · 2021-05-04T05:05:25Z

I would need this PR to be merged for final 11_3_0

But this means you will need to make a backport PR, I assume.

srimanob · 2021-05-04T05:06:59Z

+Upgrade

This PR is to add configuration in runTheMatrix. It needs to be merged together with #33407. Backport PR to 11_3_0 to be done.

cmsbuild · 2021-05-04T05:07:19Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

chayanit · 2021-05-04T05:08:43Z

Uh oh I don't know how to do the backport. What about all GEN fragments?

srimanob · 2021-05-04T05:12:38Z

Uh oh I don't know how to do the backport. What about all GEN fragments?

GEN fragment backport is in place, #33596

How to make backport:
https://cms-sw.github.io/tutorial-resolve-conflicts.html
(looking for Backporting a PR).

chayanit · 2021-05-04T05:17:31Z

There are a lot more to be backported #33409 , #33414 , #33433 and #33386 :(

qliphy · 2021-05-04T05:51:23Z

+1

cmsbuild and others added 2 commits April 18, 2021 03:35

Merge pull request cms-sw#33450 from fwyzard/Fix_EDAlias_indentation

7b59c5d

Fix indentation in EDAlias python dump

Include new processes in upgrade matrix

9c46010

cmsbuild added this to the CMSSW_12_0_X milestone Apr 19, 2021

cmsbuild added code-checks-pending orp-pending pdmv-pending pending-signatures tests-pending upgrade-pending labels Apr 19, 2021

cmsbuild added tests-started and removed tests-pending labels Apr 19, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 19, 2021

cmsbuild added tests-approved and removed tests-started labels Apr 19, 2021

cmsbuild added pdmv-approved and removed pdmv-pending labels Apr 20, 2021

add two more workflows for Tracking

84b2100

cmsbuild added code-checks-pending pdmv-pending tests-pending and removed code-checks-approved pdmv-approved tests-approved labels Apr 20, 2021

cmsbuild added code-checks-pending tests-pending and removed tests-approved labels May 3, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels May 3, 2021

cmsbuild added tests-started and removed tests-pending labels May 3, 2021

cmsbuild added tests-approved and removed tests-started labels May 3, 2021

cmsbuild added pdmv-approved and removed pdmv-pending labels May 4, 2021

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels May 4, 2021

cmsbuild added orp-approved and removed orp-pending labels May 4, 2021

cmsbuild merged commit cc65d31 into cms-sw:master May 4, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add new workflows to upgradeWorkflowComponents.py for HLT #33461

Add new workflows to upgradeWorkflowComponents.py for HLT #33461

chayanit commented Apr 19, 2021 •

edited

chayanit commented Apr 19, 2021

cmsbuild commented Apr 19, 2021

cmsbuild commented Apr 19, 2021

cmsbuild commented Apr 19, 2021

chayanit commented Apr 20, 2021

chayanit commented Apr 20, 2021

cmsbuild commented May 3, 2021

cmsbuild commented May 3, 2021

chayanit commented May 3, 2021

cmsbuild commented May 3, 2021

chayanit commented May 4, 2021

srimanob commented May 4, 2021

srimanob commented May 4, 2021

cmsbuild commented May 4, 2021

chayanit commented May 4, 2021 •

edited

srimanob commented May 4, 2021

chayanit commented May 4, 2021

qliphy commented May 4, 2021

Add new workflows to upgradeWorkflowComponents.py for HLT #33461

Add new workflows to upgradeWorkflowComponents.py for HLT #33461

Conversation

chayanit commented Apr 19, 2021 • edited

chayanit commented Apr 19, 2021

cmsbuild commented Apr 19, 2021

cmsbuild commented Apr 19, 2021

cmsbuild commented Apr 19, 2021

Comparison Summary

chayanit commented Apr 20, 2021

chayanit commented Apr 20, 2021

cmsbuild commented May 3, 2021

cmsbuild commented May 3, 2021

chayanit commented May 3, 2021

cmsbuild commented May 3, 2021

Comparison Summary

chayanit commented May 4, 2021

srimanob commented May 4, 2021

srimanob commented May 4, 2021

cmsbuild commented May 4, 2021

chayanit commented May 4, 2021 • edited

srimanob commented May 4, 2021

chayanit commented May 4, 2021

qliphy commented May 4, 2021

chayanit commented Apr 19, 2021 •

edited

chayanit commented May 4, 2021 •

edited