Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unit test in PhysicsTools/UtilAlgos #33464

Merged
merged 1 commit into from Apr 20, 2021
Merged

Fix unit test in PhysicsTools/UtilAlgos #33464

merged 1 commit into from Apr 20, 2021

Conversation

silviodonato
Copy link
Contributor

PR description:

This PR fixes a unit test failure due to a missing input file.

PR validation:

FWLiteWithBasicAnalyzer fwliteWithPythonConfig_cfg.py

@cmsbuild cmsbuild added this to the CMSSW_12_0_X milestone Apr 19, 2021
silviodonato
silviodonato commented Apr 19, 2021
View reviewed changes
PhysicsTools/UtilAlgos/test/fwliteWithPythonConfig_cfg.py
@@ -3,7 +3,7 @@
process = cms.PSet()

process.fwliteInput = cms.PSet(
fileNames = cms.vstring('root://eoscms.cern.ch//eos/cms/store/relval/CMSSW_7_2_0_pre5/RelValProdTTbar/GEN-SIM-RECO/START72_V1-v1/00000/022350A9-AC30-E411-B225-0025905A6076.root'), ## mandatory
fileNames = cms.vstring('root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/relval/CMSSW_9_3_0_pre1/RelValTTbar_13/GEN-SIM-RECO/PU25ns_92X_upgrade2017_realistic_v7-v1/00000/32EA1438-3D61-E711-8FE7-0025905B85B2.root'), ## mandatory
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smuzaffar is it ok pointing directly to a file in /eos/cms/store/user/cmsbuild ?

Copy link
Contributor

@mrodozov mrodozov Apr 20, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we make local copies to be used by the IBs so, yes.
If the file is not in cmsbuild and is available (somewhere) we copy it for the cmsbuild user.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33464/22162

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @silviodonato (Silvio Donato) for master.

It involves the following packages:

PhysicsTools/UtilAlgos

@cmsbuild, @santocch can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@silviodonato
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d63f8b/14326/summary.html
COMMIT: 652e452
CMSSW: CMSSW_12_0_X_2021-04-19-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33464/14326/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2877046
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2877023
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@silviodonato
Copy link
Contributor Author

merge

@cmsbuild cmsbuild merged commit b3d195a into cms-sw:master Apr 20, 2021
@mrodozov mrodozov mentioned this pull request Apr 20, 2021
Merged
This was referenced Apr 21, 2021
Closed
Merged
@santocch
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@qliphy qliphy mentioned this pull request May 6, 2021
Merged
@qliphy qliphy mentioned this pull request May 31, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrodozov mrodozov mrodozov left review comments

Assignees
No one assigned
Labels
analysis-approved code-checks-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_12_0_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@silviodonato @cmsbuild @santocch @mrodozov