Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

80X Backport, Add number of events, beginLumi's, and beginRun's to Jo… #33497

Merged
merged 1 commit into from Apr 22, 2021

Conversation

wddgit
Copy link
Contributor

@wddgit wddgit commented Apr 21, 2021

…bReport

PR description:

Backport of #22408 to 8_0_X

Add number of events, beginLumi's, and beginRun's to JobReport
Also adds to the output of the Timing service in the log file
Also had to backport the little ui2str function.

PR validation:

Manually ran job to examine output. Relies on validation of the original PR. Essentially this is identical to the original PR except unrelated changes on the lines immediately before or after these changes required some minor modifications.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #22408

PdmV request, See #33478

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wddgit (W. David Dagenhart) for CMSSW_8_0_X.

It involves the following packages:

FWCore/Services

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@wddgit
Copy link
Contributor Author

wddgit commented Apr 21, 2021

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d11736/14402/summary.html
COMMIT: 80a4d02
CMSSW: CMSSW_8_0_X_2021-04-18-0000/slc6_amd64_gcc530
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33497/14402/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 1044635
  • DQMHistoTests: Total failures: 844
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1043683
  • DQMHistoTests: Total skipped: 108
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -14 KiB( 14 files compared)
  • Checked 62 log files, 13 edm output root files, 15 DQM output files

@makortel
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Apr 22, 2021

+1

@cmsbuild cmsbuild merged commit 9c2992a into cms-sw:CMSSW_8_0_X Apr 22, 2021
@wddgit wddgit deleted the backport80XJobReportAdditions branch August 27, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants