MTV fast cleaning #33500

mtosi · 2021-04-22T08:37:38Z

PR description:

the Multi Track Validator (MTV) is one of the main computational and memory offenders in the VALIDATION step.
there are some not that necessary plots, and with this PR they are removed
and a new flag has been added in order to make the dzcut related performance plots on-demand

cmsbuild · 2021-04-22T08:44:22Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33500/22234

This PR adds an extra 40KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33500/22234/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33500/22234/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2021-04-22T10:28:22Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33500/22239

This PR adds an extra 36KB to repository

cmsbuild · 2021-04-22T10:28:48Z

A new Pull Request was created by @mtosi (mia tosi) for master.

It involves the following packages:

Validation/RecoTrack

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @wmtford, @ebrondol, @dgulhan this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

jfernan2 · 2021-04-22T14:45:44Z

please test

cmsbuild · 2021-04-22T17:35:04Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13f6e8/14426/summary.html
COMMIT: 723a161
CMSSW: CMSSW_12_0_X_2021-04-22-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33500/14426/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 38
DQMHistoTests: Total histograms compared: 2861106
DQMHistoTests: Total failures: 7944
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2853139
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -9231.178 KiB( 37 files compared)
DQMHistoSizes: changed ( 10024.0,... ): -345.449 KiB Tracking/Track
DQMHistoSizes: changed ( 10024.0,... ): -164.155 KiB Tracking/TrackTPPtLess09
DQMHistoSizes: changed ( 1306.0,... ): -276.117 KiB Tracking/Track
DQMHistoSizes: changed ( 1306.0,... ): -128.921 KiB Tracking/TrackTPPtLess09
DQMHistoSizes: changed ( 23234.0,... ): -229.883 KiB Tracking/Track
DQMHistoSizes: changed ( 23234.0,... ): -117.061 KiB Tracking/TrackTPEtaGreater2p7
DQMHistoSizes: changed ( 23234.0,... ): -105.425 KiB Tracking/TrackTPPtLess09
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 160 log files, 37 edm output root files, 38 DQM output files
TriggerResults: no differences found

jfernan2 · 2021-04-22T19:47:52Z

Thanks for this PR @mtosi !!
Apart from the plot removal, I see that some histograms are also being modified, mainly efficiencies, I understand they are expected due to the changes introduced, can you confirm?
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_12_0_X_2021-04-22-1100+13f6e8/42364/dqm-histo-comparison-summary.html

jfernan2 · 2021-04-26T17:39:23Z

ping @mtosi

silviodonato · 2021-05-04T13:28:40Z

kind reminder @mtosi

mtosi · 2021-05-04T14:37:59Z

apologies for the delay, there was a "feature" (aka bug), indeed
thanks for the support and patience

it should be fixed, now

cmsbuild · 2021-05-04T14:44:55Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33500/22472

This PR adds an extra 36KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33500/22472/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33500/22472/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2021-05-04T16:10:50Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33500/22474

This PR adds an extra 28KB to repository

cmsbuild · 2021-05-04T16:11:13Z

Pull request #33500 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please check and sign again.

qliphy · 2021-05-09T09:48:24Z

please test

cmsbuild · 2021-05-09T16:17:25Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13f6e8/14950/summary.html
COMMIT: d71cba3
CMSSW: CMSSW_12_0_X_2021-05-09-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33500/14950/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2648114
DQMHistoTests: Total failures: 1963
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2646129
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -8721.57 KiB( 36 files compared)
DQMHistoSizes: changed ( 10024.0,... ): -345.449 KiB Tracking/Track
DQMHistoSizes: changed ( 10024.0,... ): -164.155 KiB Tracking/TrackTPPtLess09
DQMHistoSizes: changed ( 1306.0,... ): -276.117 KiB Tracking/Track
DQMHistoSizes: changed ( 1306.0,... ): -128.921 KiB Tracking/TrackTPPtLess09
DQMHistoSizes: changed ( 23234.0,... ): -229.883 KiB Tracking/Track
DQMHistoSizes: changed ( 23234.0,... ): -117.061 KiB Tracking/TrackTPEtaGreater2p7
DQMHistoSizes: changed ( 23234.0,... ): -105.425 KiB Tracking/TrackTPPtLess09
Checked 155 log files, 37 edm output root files, 37 DQM output files
TriggerResults: no differences found

jfernan2 · 2021-05-10T08:10:52Z

+1
Thanks a lot @mtosi

cmsbuild · 2021-05-10T08:11:09Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2021-05-11T08:39:30Z

I see that this PR, for example in 10224.0_TTbar_13+2017PU+TTbar_13TeV_TuneCUETP8M1_GenSim+DigiPU+RecoFakeHLTPU+HARVESTFakeHLTPU+Nano:

Remove 660 plots in Tracks.
Specifically, the following 11 plots in 60 subfolders

effic_vs_dzpvsigcut
effic_vs_dzpvsigcut2
fakerate_vs_dzpvsigcut
globalEfficiencies
num_assoc(recoToSim)_dzpvsigcut
num_assoc(simToReco)_dzpvsigcut
num_pileup_dzpvsigcut
num_reco_dzpvsigcut
num_simul2_dzpvsigcut
num_simul_dzpvsigcut
pileuprate_dzpvsigcut

Remove 336 plots in TrackTPPtLess09.
Specifically, the following 6 plots in 56 subfolders

effic_vs_dzpvsigcut
effic_vs_dzpvsigcut2
globalEfficiencies
num_assoc(simToReco)_dzpvsigcut
num_simul2_dzpvsigcut
num_simul_dzpvsigcut

Change 60 globalEfficiencies plots in Tracks and 56 globalEfficiencies plots TrackTPPtLess09 (see example below)

Many of the removed plots were not empty.

@mtosi could you confirm that these changes are expected? Thanks

VinInn · 2021-05-11T08:47:21Z

I read "a new flag has been added in order to make the dzcut related performance plots on-demand" and understand they are now off by default.

qliphy · 2021-05-11T15:48:20Z

+1

cmsbuild added this to the CMSSW_12_0_X milestone Apr 22, 2021

cmsbuild added code-checks-pending dqm-pending orp-pending pending-signatures tests-pending labels Apr 22, 2021

cmsbuild added code-checks-rejected code-checks-pending and removed code-checks-pending code-checks-rejected labels Apr 22, 2021

mtosi force-pushed the MTVcleaning branch from 3677ddc to 723a161 Compare April 22, 2021 10:23

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 22, 2021

cmsbuild added tests-started and removed tests-pending labels Apr 22, 2021

cmsbuild added tests-approved and removed tests-started labels Apr 22, 2021

cmsbuild added alca-pending analysis-pending and removed code-checks-approved tests-approved labels May 4, 2021

cmsbuild added code-checks-rejected and removed code-checks-pending labels May 4, 2021

fix code-format

d71cba3

cmsbuild added code-checks-pending tests-pending and removed code-checks-rejected tests-started labels May 4, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels May 4, 2021

cmsbuild added tests-started and removed tests-pending labels May 9, 2021

cmsbuild added tests-approved and removed tests-started labels May 9, 2021

cmsbuild added dqm-approved and removed dqm-pending pending-signatures labels May 10, 2021

cmsbuild added the fully-signed label May 10, 2021

cmsbuild added orp-approved and removed orp-pending labels May 11, 2021

cmsbuild merged commit f0cac19 into cms-sw:master May 11, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MTV fast cleaning #33500

MTV fast cleaning #33500

mtosi commented Apr 22, 2021

cmsbuild commented Apr 22, 2021

cmsbuild commented Apr 22, 2021

cmsbuild commented Apr 22, 2021

jfernan2 commented Apr 22, 2021

cmsbuild commented Apr 22, 2021

jfernan2 commented Apr 22, 2021

jfernan2 commented Apr 26, 2021

silviodonato commented May 4, 2021

mtosi commented May 4, 2021

cmsbuild commented May 4, 2021

cmsbuild commented May 4, 2021

cmsbuild commented May 4, 2021

qliphy commented May 9, 2021

cmsbuild commented May 9, 2021

jfernan2 commented May 10, 2021

cmsbuild commented May 10, 2021

silviodonato commented May 11, 2021

VinInn commented May 11, 2021

qliphy commented May 11, 2021

MTV fast cleaning #33500

MTV fast cleaning #33500

Conversation

mtosi commented Apr 22, 2021

PR description:

cmsbuild commented Apr 22, 2021

cmsbuild commented Apr 22, 2021

cmsbuild commented Apr 22, 2021

jfernan2 commented Apr 22, 2021

cmsbuild commented Apr 22, 2021

Comparison Summary

jfernan2 commented Apr 22, 2021

jfernan2 commented Apr 26, 2021

silviodonato commented May 4, 2021

mtosi commented May 4, 2021

cmsbuild commented May 4, 2021

cmsbuild commented May 4, 2021

cmsbuild commented May 4, 2021

qliphy commented May 9, 2021

cmsbuild commented May 9, 2021

Comparison Summary

jfernan2 commented May 10, 2021

cmsbuild commented May 10, 2021

silviodonato commented May 11, 2021

VinInn commented May 11, 2021

qliphy commented May 11, 2021