PPS Pixel charge share bug fix - part 2

[fabferro]

PR description:

This PR is a follow up of PR #33329 with more code dedicated to deal with the hits at the boundary of the PPS Pixel detector.
A bug fix in the configuration parameters is also done.

PR validation:

PPS Pixel digi plots were produced. Very small expected differences in the hits at the edge of the detector.
No more errors in the logError printout.
Tests done also with 11846 wf.

if this PR is a backport please specify the original PR and why you need to backport that PR:

No backport foreseen.

@mundim FYI

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33503/22241

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @fabferro (Fabrizio Ferro) for master.

It involves the following packages:

CalibPPS/ESProducers
SimPPS/PPSPixelDigiProducer

@malbouis, @civanch, @yuanchao, @christopheralanwest, @mdhildreth, @cmsbuild, @tlampen, @pohsun, @francescobrivio can you please review it and eventually sign? Thanks.
@forthommel, @jan-kaspar, @mmusich, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[christopheralanwest]

test parameters
workflow = 11846

[christopheralanwest]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5533b1/14417/summary.html
COMMIT: 676c565
CMSSW: CMSSW_12_0_X_2021-04-22-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33503/14417/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-5533b1/11846.0_ZEE_14+2021PU+ZEE_14TeV_TuneCP5_GenSim+DigiPU+RecoPU+HARVESTPU+Nano

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2877046
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2877023
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[tlampen]

+alca

• change of configuration parameter related to PPS pixel topology + minor changes in LogError messages
• no changes expected or seen in workflows

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1