Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ECAL TPG double weight tags and remove GEMELMapRcd from GTs #33507

Merged
merged 1 commit into from Apr 23, 2021

Conversation

francescobrivio
Copy link
Contributor

@francescobrivio francescobrivio commented Apr 22, 2021

PR description:

This PR is a technical update of the GTs:

  • Adds new ECAL TPG double weights tags as requested in this HN post and further detailed in this presentation at the AlCaDB meeting.
    • Since the tags are now included in the GTs I removed SimCalorimetry/EcalTrigPrimProducers/python/ecalTrigPrimESDoubleWeights_cff.py and updated SimCalorimetry/EcalTrigPrimProducers/python/ecalTriggerPrimitiveDigis_cff.py
  • Removes the GEMELMapRcd tag from all the GTs as requested in this HN post.

GTs diff:
Run 1 design
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mcRun1_design_v2/113X_mcRun1_design_v3

Run 1 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mcRun1_realistic_v2/113X_mcRun1_realistic_v3

Run 1 heavy ion
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mcRun1_HeavyIon_v2/113X_mcRun1_HeavyIon_v3

Run 1 proton-heavy ion
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mcRun1_pA_v2/113X_mcRun1_pA_v3

Run 2 startup
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mcRun2_startup_v2/113X_mcRun2_startup_v3

Run 2 (L1 trigger stage 1)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mcRun2_asymptotic_l1stage1_v3/113X_mcRun2_asymptotic_l1stage1_v4

2016 design
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mcRun2_design_v3/113X_mcRun2_design_v4

2016 realistic pre-VFP era
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mcRun2_asymptotic_preVFP_v3/113X_mcRun2_asymptotic_preVFP_v4

2016 realistic post-VFP era
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mcRun2_asymptotic_v3/113X_mcRun2_asymptotic_v4

2016 cosmics (asymptotic conditions)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mcRun2cosmics_asymptotic_deco_v3/113X_mcRun2cosmics_asymptotic_deco_v4

Run 2 heavy ion
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mcRun2_HeavyIon_v3/113X_mcRun2_HeavyIon_v4

Run 2 proton-lead
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mcRun2_pA_v3/113X_mcRun2_pA_v4

Offline data
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_dataRun2_v5/113X_dataRun2_v6

Offline data (HEM failure)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_dataRun2_HEfail_v5/113X_dataRun2_HEfail_v6

Offline data relval
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_dataRun2_relval_v5/113X_dataRun2_relval_v6

Prompt-like HI data
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_dataRun2_PromptLike_HI_v5/113X_dataRun2_PromptLike_HI_v6

**Run 3 data HLT
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_dataRun3_HLT_v3/113X_dataRun3_HLT_v1

Run 2 HLT RelVals
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_dataRun2_HLT_relval_v6/113X_dataRun2_HLT_relval_v1

Run 3 data (express)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_dataRun3_Express_v5/113X_dataRun3_Express_v1

Run 3 data (prompt)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/112X_dataRun3_Prompt_v5/113X_dataRun3_Prompt_v1

2017 design
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mc2017_design_v4/113X_mc2017_design_v5

2017 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mc2017_realistic_v4/113X_mc2017_realistic_v5

2017 realistic cosmics (tracker deco mode)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mc2017cosmics_realistic_deco_v4/113X_mc2017cosmics_realistic_deco_v5

2017 realistic cosmics (tracker peak mode)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mc2017cosmics_realistic_peak_v4/113X_mc2017cosmics_realistic_peak_v5

2018 design
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_upgrade2018_design_v4/113X_upgrade2018_design_v5

2018 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_upgrade2018_realistic_v4/113X_upgrade2018_realistic_v5

2018 Run-dependent MC
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_upgrade2018_realistic_RD_v3/113X_upgrade2018_realistic_RD_v4

2018 heavy ion
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_upgrade2018_realistic_HI_v4/113X_upgrade2018_realistic_HI_v5

2018 realistic (HEM15/16 failure)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_upgrade2018_realistic_HEfail_v4/113X_upgrade2018_realistic_HEfail_v5

2018 cosmics (tracker deco mode)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_upgrade2018cosmics_realistic_deco_v4/113X_upgrade2018cosmics_realistic_deco_v5

2018 cosmics (tracker peak mode)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_upgrade2018cosmics_realistic_peak_v4/113X_upgrade2018cosmics_realistic_peak_v5

2021 design
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mcRun3_2021_design_v7/113X_mcRun3_2021_design_v8

2021 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mcRun3_2021_realistic_v9/113X_mcRun3_2021_realistic_v10

2021 cosmics
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mcRun3_2021cosmics_realistic_deco_v8/113X_mcRun3_2021cosmics_realistic_deco_v9

2021 heavy ion
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mcRun3_2021_realistic_HI_v7/113X_mcRun3_2021_realistic_HI_v8

2023 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mcRun3_2023_realistic_v7/113X_mcRun3_2023_realistic_v8

2024 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mcRun3_2024_realistic_v7/113X_mcRun3_2024_realistic_v8

Phase 2 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mcRun4_realistic_v6/113X_mcRun4_realistic_v7

PR validation:

Tested with:
runTheMatrix.py -l limited,140.0,1325.516,7.22,145.0,281.0,136.8642,138.2,138.1,10424.0,7.21,11224.0,250200.182,11024.2,7.4,12034.0,7.23,159.0,12834.0 --ibeos -j 9

Backport

This PR is not a backport but will be backported to 113X.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33507/22246

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @francescobrivio for master.

It involves the following packages:

Configuration/AlCa
SimCalorimetry/EcalTrigPrimProducers

@malbouis, @yuanchao, @christopheralanwest, @cmsbuild, @rekovic, @tlampen, @pohsun, @cecilecaillol, @francescobrivio can you please review it and eventually sign? Thanks.
@rchatter, @rovere, @argiro, @Martin-Grunewald, @makortel, @tocheng, @thomreis, @simonepigazzini, @mmusich, @fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@francescobrivio
Copy link
Contributor Author

test parameters:

  • workflow = 140.0,1325.516,7.22,145.0,281.0,136.8642,138.2,138.1,10424.0,7.21,11224.0,250200.182,11024.2,7.4,12034.0,7.23,159.0,12834.0

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@francescobrivio
Copy link
Contributor Author

FYI @valsdav

@valsdav
Copy link
Contributor

valsdav commented Apr 22, 2021

Hi @francescobrivio, it looks all fine from ECAL side.
Thanks a lot

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cb5373/14528/summary.html
COMMIT: b02a568
CMSSW: CMSSW_12_0_X_2021-04-22-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33507/14528/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-cb5373/10424.0_TTbar_13+2017Design+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-cb5373/11024.2_TTbar_13UP18HEfailINPUT+TTbar_13UP18HEfailINPUT+DigiFullHEfail+RecoFullHEfail+HARVESTFullHEfail+NanoFullHEfail
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-cb5373/11224.0_TTbar_13+2018Design+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-cb5373/12034.0_TTbar_14TeV+2021Design+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-cb5373/136.8642_RunJetHT2018BHEfail+RunJetHT2018BHEfail+HLTDR2_2018+RECODR2_2018reHLT_skimJetHT_Prompt_HEfail+HARVEST2018_HEfail
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-cb5373/138.1_RunCosmics2020+RunCosmics2020+RECOCOSDRUN3+ALCACOSDRUN3+HARVESTDCRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-cb5373/138.2_RunCosmics2020+RunCosmics2020+RECOCOSDEXPRUN3+ALCACOSDEXPRUN3+HARVESTDCEXPRUN3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-cb5373/140.0_HydjetQ_B12_5020GeV_2011+HydjetQ_B12_5020GeV_2011+DIGIHI2011+RECOHI2011+HARVESTHI2011
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-cb5373/145.0_HydjetQ_B12_5020GeV_2015+HydjetQ_B12_5020GeV_2015+DIGIHI2015+RECOHI2015+HARVESTHI2015
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-cb5373/250200.182_ZEE_13UP18_RD+ZEE_13UP18_RD+DIGIPRMXUP18_PU25_RD+RECOPRMXUP18_PU25_L1TEgDQM_RD+HARVESTUP18_PU25_L1TEgDQM_RD
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-cb5373/7.21_Cosmics_UP17+Cosmics_UP17+DIGICOS_UP17+RECOCOS_UP17+ALCACOS_UP17+HARVESTCOS_UP17
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-cb5373/7.22_Cosmics_UP16+Cosmics_UP16+DIGICOS_UP16+RECOCOS_UP16+ALCACOS_UP16+HARVESTCOS_UP16
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-cb5373/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2877046
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2877023
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@christopheralanwest
Copy link
Contributor

+1

  • Purely technical change moves tags from hardcoded ESSource to GT
  • No changes expected or observed in any workflow

@cecilecaillol
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Apr 23, 2021

+1

@cmsbuild cmsbuild merged commit 50f5fd4 into cms-sw:master Apr 23, 2021
@francescobrivio francescobrivio deleted the alca-EcalTPGdoubleweights branch June 16, 2021 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants