New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validation/RecoEgamma remove recomp histos from miniAOD Validation #33575
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33575/22373
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33575/22374
|
A new Pull Request was created by @archiron (Chiron) for master. It involves the following packages: Validation/RecoEgamma @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ecaaa5/14703/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Removing of unused recomp plots in miniAOD EGamma Validation (Validation/RecoEgamma/plugins/ElectronMcMiniAODSignalValidator.cc/h). Those histograms are comparing the PF-isolation computed at the RECO-level and that re-computed on-the-fly from the PF candidates (this comparison is done with a different plotting tool, not in DQM).
These histograms were not much useful and we drop them.
PR validation:
compilation is OK, basics tests (scram b runtests or local tests) are OK too.
runTheMatrix.py -l limited -i all --ibeos tests are fine (38 37 36 27 17 4 1 1 1 tests passed, 0 0 0 0 0 0 0 0 0 failed).
here is the run-log :
runall-report-step123-.log
if this PR is a backport please specify the original PR and why you need to backport that PR:
Before submitting your pull requests, make sure you followed this checklist:
@beaudett