Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use genTauJet modules coherently across different nanoAOD cffs (106X) #33590

Conversation

mbluj
Copy link
Contributor

@mbluj mbluj commented Apr 30, 2021

PR description:

In this PR genTauJets and related table modules are put into a new sequence called genTauSequence with is then used in the original tauMC sequence and in nanogenSequence in nanogen_cff.py. Name of a tauGenJets module is also updated in the latter cff. Those developments are purely technical and fix issue reported in #33578 and introduced by #33525 without changing physics content.

PR validation:

Tested with runTheMatrix.py -l 546,547,548 -i all --ibeos

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #33586 to 106X for NanoAODv9

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mbluj for CMSSW_10_6_X.

It involves the following packages:

PhysicsTools/NanoAOD

@cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please review it and eventually sign? Thanks.
@gpetruc, @swertz this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mariadalfonso
Copy link
Contributor

please test workflow 546,547,548

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3a3279/14750/summary.html
COMMIT: 2a0555f
CMSSW: CMSSW_10_6_X_2021-04-30-1100/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33590/14750/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-3a3279/546.0_DYToLL_M-50_13TeV_pythia8+DYToLL_M-50_13TeV_pythia8+NANOGENFromGen
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-3a3279/547.0_DYToll01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV+DYToll01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV+Hadronizer_TuneCP5_13TeV_MLM_5f_max4j_LHE_pythia8+NANOGENFromGen
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-3a3279/548.0_TTbar_Pow_LHE_13TeV+TTbar_Pow_LHE_13TeV+Hadronizer_TuneCP5_13TeV_powhegEmissionVeto2p_pythia8+NANOGENFromGen

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 3215544
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3215209
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 143 log files, 29 edm output root files, 35 DQM output files
  • TriggerResults: no differences found

@mariadalfonso
Copy link
Contributor

+xpog

@cmsbuild
Copy link
Contributor

cmsbuild commented May 1, 2021

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@mariadalfonso
Copy link
Contributor

bugfix

@qliphy
Copy link
Contributor

qliphy commented May 1, 2021

type bugfix

@qliphy
Copy link
Contributor

qliphy commented May 1, 2021

+1

@cmsbuild cmsbuild merged commit 9b2c5ce into cms-sw:CMSSW_10_6_X May 1, 2021
@mbluj mbluj deleted the CMSSW_10_6_X_tau-pog_genPartsForGenTauAtnano branch May 10, 2021 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants