Bug fix for tag lock clean up at session closing time

[ggovi]

PR description:

We provide a fix for a bug affecting the implicit cleanup of Tag locks when a DB session is being closed/deleted.
The available testing workflow has been rewritten to provide a more representative test case.

PR validation:

Unit tests and integration tests.

Backport of #33603
This code is required in the online operation of the HLT workflow.

[cmsbuild]

A new Pull Request was created by @ggovi for CMSSW_11_3_X.

It involves the following packages:

CondCore/CondDB
CondCore/DBOutputService

@malbouis, @yuanchao, @cmsbuild, @tlampen, @ggovi, @pohsun, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from Bug fix for tag lock clean up at session closing time #33603

[francescobrivio]

@cmsbuild please test

[francescobrivio]

backport #33603

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a6432d/14898/summary.html
COMMIT: 21eea22
CMSSW: CMSSW_11_3_X_2021-05-05-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33629/14898/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2877046
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2877017
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[francescobrivio]

There are few failures and Reco differences that were not present in the master PR tests, not sure why the appeared in the 113X backport...

[ggovi]

+1

[francescobrivio]

+alca

• backport
• failures and differences all related to MessageLogger

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1