[HGCAL] SimTracksters from Caloparticles #33638

felicepantaleo · 2021-05-05T15:25:32Z

PR description:

This PR improves SimTracksters by:

taking into account the correct fraction of the energy of the layer cluster for the calculation of the energy of the trackster and its PCA (data format change was needed)
using the caloparticle as a source for layercluster if the caloparticle crossed the CALO volume boundary, otherwise use the simclusters.
I expect changes in the number of simtracksters (I expect a smaller number of them)

PR validation:

validated using 23293.0

felicepantaleo · 2021-05-05T15:28:49Z

@cmsbuild please test

slava77 · 2021-05-05T15:32:43Z

DataFormats/HGCalReco/interface/Trackster.h

@@ -153,7 +153,7 @@ namespace ticl {
    // The vertices of the DAG are the indices of the
    // 2d objects in the global collection
    std::vector<unsigned int> vertices_;
-    std::vector<uint8_t> vertex_multiplicity_;
+    std::vector<float> vertex_multiplicity_;


I'm curious if the schema evolution handles this appropriately.
@felicepantaleo please clarify/confirm that tracksters from the old files are still correctly readable.

I could run the trackster validation on old files with this branch.

cmsbuild · 2021-05-05T15:33:37Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33638/22508

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/HGCalReco/interface/Trackster.h modified in PR(s): [DD4hep] start on geometry XML payload producer #33548
- File RecoHGCal/TICL/plugins/TrackstersFromSimClustersProducer.cc modified in PR(s): [DD4hep] start on geometry XML payload producer #33548

cmsbuild · 2021-05-05T15:34:04Z

A new Pull Request was created by @felicepantaleo (Felice Pantaleo) for master.

It involves the following packages:

DataFormats/HGCalReco
RecoHGCal/TICL

@perrotta, @jpata, @srimanob, @kpedro88, @slava77 can you please review it and eventually sign? Thanks.
@rovere, @apsallid, @sobhatta, @lecriste, @hatakeyamak, @ebrondol, @clelange this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2021-05-05T16:50:54Z

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-81c9a3/14889/summary.html
COMMIT: 5a23cbc
CMSSW: CMSSW_12_0_X_2021-05-04-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33638/14889/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

34834.999

----- Begin Fatal Exception 05-May-2021 18:37:02 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'validation_step9'
   [2] Prefetching for module HGCalValidator/'hgcalValidator'
   [3] Calling method for module TrackstersFromSimClustersProducer/'ticlSimTracksters'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector<CaloParticle>
Looking for module label: mix
Looking for productInstanceName: MergedCaloTruth

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

kpedro88 · 2021-05-05T16:54:51Z

@felicepantaleo you need to propagate the premixing modification to the new caloparticles parameter:

cmssw/RecoHGCal/TICL/python/SimTracksters_cff.py

Line 23 in 5a23cbc

simclusters = "mixData:MergedCaloTruth"

felicepantaleo · 2021-05-05T17:15:47Z

@cmsbuild please test

felicepantaleo · 2021-05-06T10:32:52Z

@cmsbuild please test

cmsbuild · 2021-05-06T10:38:03Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33638/22520

This PR adds an extra 24KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/HGCalReco/interface/Trackster.h modified in PR(s): [DD4hep] start on geometry XML payload producer #33548
- File RecoHGCal/TICL/plugins/TrackstersFromSimClustersProducer.cc modified in PR(s): [DD4hep] start on geometry XML payload producer #33548
- File RecoHGCal/TICL/python/SimTracksters_cff.py modified in PR(s): [DD4hep] start on geometry XML payload producer #33548

cmsbuild · 2021-05-06T10:38:24Z

Pull request #33638 was updated. @perrotta, @jpata, @srimanob, @kpedro88, @slava77 can you please check and sign again.

felicepantaleo · 2021-05-06T10:40:58Z

ok, I think I am done with it...

cmsbuild · 2021-05-06T13:25:13Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-81c9a3/14908/summary.html
COMMIT: 5ed978a
CMSSW: CMSSW_12_0_X_2021-05-05-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33638/14908/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

No significant changes to the logs found
Reco comparison results: 1263 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2662646
DQMHistoTests: Total failures: 8395
DQMHistoTests: Total nulls: 19
DQMHistoTests: Total successes: 2654210
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -45.703 KiB( 36 files compared)
DQMHistoSizes: changed ( 140.53 ): -44.531 KiB Hcal/DigiRunHarvesting
DQMHistoSizes: changed ( 140.53 ): -1.172 KiB RPC/DCSInfo
Checked 155 log files, 37 edm output root files, 37 DQM output files
TriggerResults: no differences found

jpata · 2021-05-07T08:30:39Z

+reconstruction

no unexpected/relevant changes

srimanob · 2021-05-07T10:58:19Z

Hi @felicepantaleo

Is this something you expect?
https://tinyurl.com/yf2sc7ln

felicepantaleo · 2021-05-10T12:17:43Z

@srimanob yes, definitely

srimanob · 2021-05-10T12:21:39Z

+Upgrade

This PR is expected to improve SimTracksters. Changes have been seen, and they are expected as confirmed by HGCAL.

cmsbuild · 2021-05-10T12:22:00Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2021-05-10T12:54:14Z

+1

felicepantaleo added 3 commits May 5, 2021 14:40

Use caloparticles when boundary crossed, otherwise use simclusters.

f3e5e16

modify Tracksters to have a float vertex multiplicity

dc5f519

using float multiplicity for fraction

5a23cbc

cmsbuild added this to the CMSSW_12_0_X milestone May 5, 2021

cmsbuild added code-checks-pending orp-pending pending-signatures reconstruction-pending tests-pending upgrade-pending labels May 5, 2021

cmsbuild added tests-started and removed tests-pending labels May 5, 2021

slava77 reviewed May 5, 2021

View reviewed changes

cmsbuild added code-checks-approved and removed code-checks-pending labels May 5, 2021

cmsbuild added tests-rejected and removed tests-started labels May 5, 2021

add premix modifier

c20860c

cmsbuild added code-checks-pending tests-pending tests-started and removed code-checks-approved tests-rejected tests-pending labels May 5, 2021

cmsbuild added code-checks-pending tests-pending and removed tests-approved labels May 6, 2021

cmsbuild added tests-started and removed tests-pending labels May 6, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels May 6, 2021

cmsbuild added tests-approved and removed tests-started labels May 6, 2021

cmsbuild added reconstruction-approved and removed reconstruction-pending labels May 7, 2021

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels May 10, 2021

cmsbuild added orp-approved and removed orp-pending labels May 10, 2021

cmsbuild merged commit 245403f into cms-sw:master May 10, 2021

cmsbuild mentioned this pull request May 11, 2021

Use .length instead of strlen() in AMPTHadronizer #33687

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HGCAL] SimTracksters from Caloparticles #33638

[HGCAL] SimTracksters from Caloparticles #33638

felicepantaleo commented May 5, 2021

felicepantaleo commented May 5, 2021

slava77 May 5, 2021

felicepantaleo May 6, 2021

cmsbuild commented May 5, 2021

cmsbuild commented May 5, 2021

cmsbuild commented May 5, 2021

kpedro88 commented May 5, 2021

felicepantaleo commented May 5, 2021

felicepantaleo commented May 6, 2021

cmsbuild commented May 6, 2021

cmsbuild commented May 6, 2021

felicepantaleo commented May 6, 2021

cmsbuild commented May 6, 2021

jpata commented May 7, 2021

srimanob commented May 7, 2021

felicepantaleo commented May 10, 2021

srimanob commented May 10, 2021

cmsbuild commented May 10, 2021

qliphy commented May 10, 2021

[HGCAL] SimTracksters from Caloparticles #33638

[HGCAL] SimTracksters from Caloparticles #33638

Conversation

felicepantaleo commented May 5, 2021

PR description:

PR validation:

felicepantaleo commented May 5, 2021

slava77 May 5, 2021

Choose a reason for hiding this comment

felicepantaleo May 6, 2021

Choose a reason for hiding this comment

cmsbuild commented May 5, 2021

cmsbuild commented May 5, 2021

cmsbuild commented May 5, 2021

RelVals

kpedro88 commented May 5, 2021

felicepantaleo commented May 5, 2021

felicepantaleo commented May 6, 2021

cmsbuild commented May 6, 2021

cmsbuild commented May 6, 2021

felicepantaleo commented May 6, 2021

cmsbuild commented May 6, 2021

Comparison Summary

jpata commented May 7, 2021

srimanob commented May 7, 2021

felicepantaleo commented May 10, 2021

srimanob commented May 10, 2021

cmsbuild commented May 10, 2021

qliphy commented May 10, 2021