Fix circular dependency between RecoEgamma and RecoEcal

[swagata87]

PR description:

This is a purely technical PR and no change in physics is expected. It was pointed out by @davidlange6 in this comment that in my past PR (#33148) I had introduced a circular dependency between RecoEgamma and RecoEcal. I'm fixing that in this PR.

PR validation:

runTheMatrix.py limited test with 23234.0 and 136.793

This PR is not a backport.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33653/22539

• This PR adds an extra 60KB to repository

[cmsbuild]

A new Pull Request was created by @swagata87 (Swagata Mukherjee) for master.

It involves the following packages:

RecoEcal/EgammaCoreTools
RecoEgamma/EgammaElectronAlgos
RecoEgamma/EgammaElectronProducers
RecoEgamma/EgammaHLTProducers
RecoEgamma/EgammaPhotonProducers

@perrotta, @cmsbuild, @slava77, @Martin-Grunewald, @fwyzard, @jpata can you please review it and eventually sign? Thanks.
@sscruz, @Sam-Harper, @lecriste, @rchatter, @jainshilpi, @sobhatta, @rovere, @lgray, @calderona, @HuguesBrun, @Fedespring, @thomreis, @afiqaize, @simonepigazzini, @argiro, @varuns23, @cericeci, @ram1123 this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6ea199/14925/summary.html
COMMIT: 05ae7d1
CMSSW: CMSSW_12_0_X_2021-05-06-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33653/14925/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS Clang-Tidy warnings: There are Clang-Tidy warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6ea199/14925/llvm-analysis/cmsclangtidy.txt for details.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2662646
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2662617
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[Martin-Grunewald]

+1

[slava77]

+reconstruction

for #33653 05ae7d1

• this is a technical update, as described in the title and the PR description

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1