Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beamspot and vertex smaring for 2017 pp ref (forward port of #33504) #33655

Merged

Conversation

tlampen
Copy link
Contributor

@tlampen tlampen commented May 7, 2021

PR description:

This is a forward port of PR #33504 with respect to: 1) in autoCond.py a new global tag was created and added for MC production with realistic conditions for Phase1 2017 detector for PP reference run, and 2) relval_steps.py was updated for ppRefAlca2017 pp reference test, so that it uses the new global tag and correct beamspot.

This forward port is discussed in AlCaDB HN: https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4390/1/1/1/1/1/1/1/1/1/1/1/1/2/1.html .

GT difference wrt. the base GT 113X_mc2017_realistic_v5 [1] is the same as the difference [2] of standard pp collisions vs. pp reference run in 10_6_X.

PR validation:

Workflow 149 was tested.

if this PR is a backport please specify the original PR and why you need to backport that PR:

This is a forward port of #33504, which is kept on hold until this PR to master is approved and merged.

[1]
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mc2017_realistic_v5/120X_mc2017_realistic_forppRef5TeV_v1
[2]
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_mc2017_realistic_v9/106X_mc2017_realistic_forppRef5TeV_v3

@tlampen
Copy link
Contributor Author

tlampen commented May 7, 2021

test parameters
workflow = 149

@tlampen
Copy link
Contributor Author

tlampen commented May 7, 2021

FYI @mandrenguyen

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33655/22546

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2021

A new Pull Request was created by @tlampen (Tapio Lampén) for master.

It involves the following packages:

Configuration/AlCa
Configuration/PyReleaseValidation

@malbouis, @yuanchao, @jordan-martins, @chayanit, @wajidalikhan, @kpedro88, @cmsbuild, @srimanob, @tlampen, @pohsun, @francescobrivio can you please review it and eventually sign? Thanks.
@makortel, @tocheng, @Martin-Grunewald, @mmusich, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@francescobrivio
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f47bcf/14937/summary.html
COMMIT: 6819baf
CMSSW: CMSSW_12_0_X_2021-05-06-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33655/14937/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-f47bcf/149.0_QCD_Pt_80_120_13_PPREF+QCD_Pt_80_120_13_PPREF+DIGIPPREF2017+RECOPPREF2017+HARVESTPPREF2017

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2662646
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2662617
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 155 log files, 37 edm output root files, 37 DQM output files
  • TriggerResults: no differences found

@tlampen
Copy link
Contributor Author

tlampen commented May 10, 2021

@mandrenguyen Can you confirm that this PR is sufficient to forward-port #33504? In #33504 there were changes also in three other files introducing a new beamspot option, but these changes were already included via #28573 .

@mandrenguyen
Copy link
Contributor

Thanks @tlampen
I confirm.
The vertex smearing is already in the frontier release.
It's only the GT, which was not available.
For #33504 the vertex smearing was not available, as this seems to have been introduced after 10_6_X (the UL release) and then only backported to 9_4_X ( the data-taking release).

@francescobrivio
Copy link
Contributor

+alca

@srimanob
Copy link
Contributor

+Upgrade

@francescobrivio
Copy link
Contributor

@cms-sw/pdmv-l2 could you review this PR?
We need this approved/merged to unhold the 106X PR ( #33504 ) and to avoid conflicts with the upcoming PR to include the UL2016 JEC tags. Thanks!

@chayanit
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented May 11, 2021

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants