-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Beamspot and vertex smaring for 2017 pp ref (forward port of #33504) #33655
Beamspot and vertex smaring for 2017 pp ref (forward port of #33504) #33655
Conversation
test parameters |
FYI @mandrenguyen |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33655/22546
|
A new Pull Request was created by @tlampen (Tapio Lampén) for master. It involves the following packages: Configuration/AlCa @malbouis, @yuanchao, @jordan-martins, @chayanit, @wajidalikhan, @kpedro88, @cmsbuild, @srimanob, @tlampen, @pohsun, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f47bcf/14937/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
@mandrenguyen Can you confirm that this PR is sufficient to forward-port #33504? In #33504 there were changes also in three other files introducing a new beamspot option, but these changes were already included via #28573 . |
Thanks @tlampen |
+alca
|
+Upgrade |
@cms-sw/pdmv-l2 could you review this PR? |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This is a forward port of PR #33504 with respect to: 1) in autoCond.py a new global tag was created and added for MC production with realistic conditions for Phase1 2017 detector for PP reference run, and 2) relval_steps.py was updated for ppRefAlca2017 pp reference test, so that it uses the new global tag and correct beamspot.
This forward port is discussed in AlCaDB HN: https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4390/1/1/1/1/1/1/1/1/1/1/1/1/2/1.html .
GT difference wrt. the base GT 113X_mc2017_realistic_v5 [1] is the same as the difference [2] of standard pp collisions vs. pp reference run in 10_6_X.
PR validation:
Workflow 149 was tested.
if this PR is a backport please specify the original PR and why you need to backport that PR:
This is a forward port of #33504, which is kept on hold until this PR to master is approved and merged.
[1]
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_mc2017_realistic_v5/120X_mc2017_realistic_forppRef5TeV_v1
[2]
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_mc2017_realistic_v9/106X_mc2017_realistic_forppRef5TeV_v3