MTD validation: optional histograms of BTL and ETL uncalibrated RecHits #33662

casarsa · 2021-05-07T14:35:55Z

This PR introduces some optional histograms of the BTL and ETL uncalibrated RecHits to check the hit time resolution as a function of the hit amplitude and the hit pseudorapidity. The booking and filling of the new histograms is optional and can be switched on with a configuration flag: the default is OFF.

A ROOT macro is also provided to analyse the uncalibrated RecHits histograms.

PR validation:

The new code has been tested with both the new feature OFF and ON using the WF 34634.0 with CMSSW_12_0_X_2021-05-06-2300.

current code (step 3):

MemoryReport> Peak virtual size 6392.12 Mbytes
Key events increasing vsize:
[0] run: 0 lumi: 0 event: 0 vsize = 0 deltaVsize = 0 rss = 0 delta = 0
[1] run: 1 lumi: 1 event: 1 vsize = 6392.07 deltaVsize = 0 rss = 3387.42 delta = 0
[2] run: 1 lumi: 1 event: 2 vsize = 6392.11 deltaVsize = 0.046875 rss = 3442.12 delta = 54.6953
[8] run: 1 lumi: 1 event: 8 vsize = 6392.12 deltaVsize = 0.0078125 rss = 3302.1 delta = -140.02
[0] run: 0 lumi: 0 event: 0 vsize = 0 deltaVsize = 0 rss = 0 delta = 0
[10] run: 1 lumi: 1 event: 10 vsize = 6392.12 deltaVsize = 0 rss = 3322.02 delta = 19.918
[9] run: 1 lumi: 1 event: 9 vsize = 6392.12 deltaVsize = 0 rss = 3323.58 delta = 21.4805
[8] run: 1 lumi: 1 event: 8 vsize = 6392.12 deltaVsize = 0.0078125 rss = 3302.1 delta = -140.02
TimeReport> Time report complete in 227.177 seconds
Time Summary:

Min event: 2.46557
Max event: 18.1748
Avg event: 5.5697
Total loop: 113.632
Total init: 109.26
Total job: 227.177
EventSetup Lock: 0
EventSetup Get: 0
Event Throughput: 0.088003 ev/s
CPU Summary:
Total loop: 105.267
Total init: 137.419
Total extra: 0
Total job: 246.414
Processing Summary:
Number of Events: 10
Number of Global Begin Lumi Calls: 1
Number of Global Begin Run Calls: 1

Size of the MTD histograms in the DQM root file:
1129.74 KiB MTD/ETL
239.63 KiB MTD/BTL

new code with new feature OFF (step 3):

MemoryReport> Peak virtual size 6366.38 Mbytes
Key events increasing vsize:
[0] run: 0 lumi: 0 event: 0 vsize = 0 deltaVsize = 0 rss = 0 delta = 0
[1] run: 1 lumi: 1 event: 1 vsize = 6366.33 deltaVsize = 0 rss = 3401.11 delta = 0
[2] run: 1 lumi: 1 event: 2 vsize = 6366.38 deltaVsize = 0.046875 rss = 3462.15 delta = 61.0352
[8] run: 1 lumi: 1 event: 8 vsize = 6366.38 deltaVsize = 0.0078125 rss = 3507.35 delta = 45.1992
[0] run: 0 lumi: 0 event: 0 vsize = 0 deltaVsize = 0 rss = 0 delta = 0
[10] run: 1 lumi: 1 event: 10 vsize = 6366.38 deltaVsize = 0 rss = 3527.03 delta = 19.6797
[9] run: 1 lumi: 1 event: 9 vsize = 6366.38 deltaVsize = 0 rss = 3525.76 delta = 18.4102
[8] run: 1 lumi: 1 event: 8 vsize = 6366.38 deltaVsize = 0.0078125 rss = 3507.35 delta = 45.1992
TimeReport> Time report complete in 234.941 seconds
Time Summary:

Min event: 2.32497
Max event: 16.4596
Avg event: 5.0602
Total loop: 116.285
Total init: 114.081
Total job: 234.941
EventSetup Lock: 0
EventSetup Get: 0
Event Throughput: 0.0859958 ev/s
CPU Summary:
Total loop: 97.7062
Total init: 137.679
Total extra: 0
Total job: 239.228
Processing Summary:
Number of Events: 10
Number of Global Begin Lumi Calls: 1
Number of Global Begin Run Calls: 1

Size of the MTD histograms in the DQM root file:
1129.74 KiB MTD/ETL
239.63 KiB MTD/BTL

new code with new feature ON (step 3):

MemoryReport> Peak virtual size 6366.63 Mbytes
Key events increasing vsize:
[1] run: 1 lumi: 1 event: 1 vsize = 5854.57 deltaVsize = 0 rss = 3397.2 delta = 0
[2] run: 1 lumi: 1 event: 2 vsize = 5854.62 deltaVsize = 0.046875 rss = 3455.33 delta = 58.125
[4] run: 1 lumi: 1 event: 4 vsize = 6366.62 deltaVsize = 512 rss = 3481.23 delta = 25.9062
[8] run: 1 lumi: 1 event: 8 vsize = 6366.63 deltaVsize = 0.0078125 rss = 3500.05 delta = 18.8164
[0] run: 0 lumi: 0 event: 0 vsize = 0 deltaVsize = 0 rss = 0 delta = 0
[10] run: 1 lumi: 1 event: 10 vsize = 6366.63 deltaVsize = 0 rss = 3517.79 delta = 17.7422
[9] run: 1 lumi: 1 event: 9 vsize = 6366.63 deltaVsize = 0 rss = 3523.39 delta = 23.3438
[8] run: 1 lumi: 1 event: 8 vsize = 6366.63 deltaVsize = 0.0078125 rss = 3500.05 delta = 18.8164
TimeReport> Time report complete in 238.522 seconds
Time Summary:

Min event: 2.42648
Max event: 17.5428
Avg event: 5.27197
Total loop: 116.606
Total init: 117.143
Total job: 238.522
EventSetup Lock: 0
EventSetup Get: 0
Event Throughput: 0.0857586 ev/s
CPU Summary:
Total loop: 99.5613
Total init: 136.715
Total extra: 0
Total job: 240.332
Processing Summary:
Number of Events: 10
Number of Global Begin Lumi Calls: 1
Number of Global Begin Run Calls: 1

Size of the MTD histograms in the DQM root file:
1205.19 KiB MTD/ETL
509.57 KiB MTD/BTL

@fabiocos @parbol @gsorrentino18

cmsbuild · 2021-05-07T14:43:01Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33662/22555

This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33662/22555/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33662/22555/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

…or the BTL and ETL time resolutions and a ROOT macro to analyze them.

cmsbuild · 2021-05-07T15:02:05Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33662/22556

This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33662/22556/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33662/22556/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2021-05-07T15:14:36Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33662/22558

This PR adds an extra 28KB to repository
Found files with invalid states:
- Validation/MtdValidation/macro/makeTimeResPlots.C:
  - Added: defee1c
  - Deleted: d3b4d12

cmsbuild · 2021-05-07T15:14:56Z

A new Pull Request was created by @casarsa (Massimo Casarsa) for master.

It involves the following packages:

Validation/MtdValidation

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

fabiocos · 2021-05-09T15:36:37Z

please test

fabiocos · 2021-05-09T15:37:13Z

@casarsa I assume you already tested the update with the flags activated

cmsbuild · 2021-05-09T18:08:05Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-32fda8/14952/summary.html
COMMIT: 8448038
CMSSW: CMSSW_12_0_X_2021-05-09-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33662/14952/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2663174
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2663145
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 155 log files, 37 edm output root files, 37 DQM output files
TriggerResults: no differences found

jfernan2 · 2021-05-10T08:15:29Z

+1

cmsbuild · 2021-05-10T08:15:49Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

casarsa · 2021-05-10T09:06:11Z

@casarsa I assume you already tested the update with the flags activated

Yes. Activating the flags has no significant impact on the RAM usage and execution time, while it increases the DQM root file by 345.4 kB.

fabiocos · 2021-05-10T10:08:09Z

@casarsa and of course you verified that the output is what expected an usable with the macro, am I correct?

casarsa · 2021-05-10T10:13:32Z

It goes without saying.

qliphy · 2021-05-10T12:56:08Z

+1

cmsbuild added this to the CMSSW_12_0_X milestone May 7, 2021

cmsbuild added code-checks-pending dqm-pending orp-pending pending-signatures tests-pending labels May 7, 2021

cmsbuild added code-checks-rejected and removed code-checks-pending labels May 7, 2021

casarsa added 2 commits May 7, 2021 16:49

Added optional histograms of BTL and ETL UncalibratedRecHits to monit…

defee1c

…or the BTL and ETL time resolutions and a ROOT macro to analyze them.

Applied code-format and renamed macro to macros

a92841d

casarsa force-pushed the mc-mtdValidationUpdate branch from 66de3d1 to a92841d Compare May 7, 2021 14:56

cmsbuild added code-checks-pending and removed code-checks-rejected labels May 7, 2021

cmsbuild added code-checks-rejected and removed code-checks-pending labels May 7, 2021

casarsa added 2 commits May 7, 2021 17:05

Removed the macro folder

d3b4d12

Applied code-format

8448038

cmsbuild added code-checks-pending and removed code-checks-rejected labels May 7, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels May 7, 2021

cmsbuild added tests-started and removed tests-pending labels May 9, 2021

cmsbuild added tests-approved and removed tests-started labels May 9, 2021

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels May 10, 2021

cmsbuild added orp-approved and removed orp-pending labels May 10, 2021

cmsbuild merged commit a6d09e9 into cms-sw:master May 10, 2021

cmsbuild mentioned this pull request May 11, 2021

Use .length instead of strlen() in AMPTHadronizer #33687

Merged

casarsa deleted the mc-mtdValidationUpdate branch December 2, 2022 14:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MTD validation: optional histograms of BTL and ETL uncalibrated RecHits #33662

MTD validation: optional histograms of BTL and ETL uncalibrated RecHits #33662

casarsa commented May 7, 2021

cmsbuild commented May 7, 2021

cmsbuild commented May 7, 2021

cmsbuild commented May 7, 2021

cmsbuild commented May 7, 2021

fabiocos commented May 9, 2021

fabiocos commented May 9, 2021

cmsbuild commented May 9, 2021

jfernan2 commented May 10, 2021

cmsbuild commented May 10, 2021

casarsa commented May 10, 2021

fabiocos commented May 10, 2021

casarsa commented May 10, 2021

qliphy commented May 10, 2021

MTD validation: optional histograms of BTL and ETL uncalibrated RecHits #33662

MTD validation: optional histograms of BTL and ETL uncalibrated RecHits #33662

Conversation

casarsa commented May 7, 2021

PR validation:

cmsbuild commented May 7, 2021

cmsbuild commented May 7, 2021

cmsbuild commented May 7, 2021

cmsbuild commented May 7, 2021

fabiocos commented May 9, 2021

fabiocos commented May 9, 2021

cmsbuild commented May 9, 2021

Comparison Summary

jfernan2 commented May 10, 2021

cmsbuild commented May 10, 2021

casarsa commented May 10, 2021

fabiocos commented May 10, 2021

casarsa commented May 10, 2021

qliphy commented May 10, 2021