[HGCAL] Move plugins out of SimDataFormats

[lecriste]

PR description:

This PR moves the plugins recently added into SimDataFormats/Associations to SimCalorimetry/HGCalAssociatorProducers and uniform the naming of associators files.
No changes are expected in the output.

PR validation:

runTheMatrix -l limited

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33664/22560

• This PR adds an extra 28KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33664/22560/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33664/22560/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33664/22561

• This PR adds an extra 28KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33664/22561/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33664/22561/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33664/22562

• This PR adds an extra 32KB to repository

[cmsbuild]

A new Pull Request was created by @lecriste (Leonardo Cristella) for master.

It involves the following packages:

SimCalorimetry/HGCalAssociatorProducers
SimDataFormats/Associations

@cmsbuild, @srimanob, @civanch, @mdhildreth, @kpedro88 can you please review it and eventually sign? Thanks.
@apsallid, @ebrondol, @fabiocos, @rovere this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[rovere]

@cmsbuild please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33664/22583

• This PR adds an extra 32KB to repository

[cmsbuild]

Pull request #33664 was updated. @cmsbuild, @srimanob, @civanch, @mdhildreth, @kpedro88 can you please check and sign again.

[srimanob]

Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b01bf1/14983/summary.html
COMMIT: c7ccf63
CMSSW: CMSSW_12_0_X_2021-05-10-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33664/14983/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 5 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2663174
• DQMHistoTests: Total failures: 12
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2663139
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 36 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[lecriste]

@srimanob the error in Static Check build is fixed now.

[lecriste]

@civanch can you please review again this PR? The only changes from previous signoff are for LogDebug.

[srimanob]

+Upgrade

This is considered to be technical PR, moving plugins from SimDataFormats to SimCalorimetry, and uniform the naming. PR test passed without change (as expected)

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1

[silviodonato]

@lecriste have you forgotten some #ifndef PackageName_SubPackageName_FileName_h in the header files? (see https://cms-sw.github.io/cms_coding_rules.html)