Subdirectories for GEM-CSC LUTs #33677

dildick · 2021-05-10T15:15:50Z

PR description:

GEM-CSC LUTs are being organized into subdirectories

CoordinateConversion (already filled): coordinate GEM strip and eta partition number to CSC half-strip and wiregroup
SlopeCorrection (coming in next PR): for finding accurate GEM trigger matches
BendingAngle (coming in next PR): for assigning the bending angle to be used in the Run-3 EMTF.

This should fix the issue in cms-data/L1Trigger-CSCTriggerPrimitives#8

PR validation:

Code compiles.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

cmsbuild · 2021-05-10T15:23:28Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33677/22579

This PR adds an extra 16KB to repository

cmsbuild · 2021-05-10T15:23:55Z

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

L1Trigger/CSCTriggerPrimitives

@cmsbuild, @rekovic, @cecilecaillol can you please review it and eventually sign? Thanks.
@valuev, @ptcox, @Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

cecilecaillol · 2021-05-10T15:31:44Z

please test

cmsbuild · 2021-05-10T16:48:04Z

-1

Failed Tests: RelVals RelVals-INPUT AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fcefa3/14968/summary.html
COMMIT: ff05d35
CMSSW: CMSSW_12_0_X_2021-05-10-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33677/14968/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

312.0

----- Begin Fatal Exception 10-May-2021 17:51:35 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=CSCTriggerPrimitivesProducer label='simCscTriggerPrimitiveDigis'
Exception Message:
edm::FileInPath unable to find file L1Trigger/CSCTriggerPrimitives/data/GEMCSC/CoordinateConversion/GEMCSCLUT_pad_hs_ME1a_even.txt anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33677/14968/CMSSW_12_0_X_2021-05-10-1100/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33677/14968/CMSSW_12_0_X_2021-05-10-1100/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33677/14968/CMSSW_12_0_X_2021-05-10-1100/external/slc7_amd64_gcc900/data:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw-patch/CMSSW_12_0_X_2021-05-10-1100/poison:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw-patch/CMSSW_12_0_X_2021-05-10-1100/src:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw-patch/CMSSW_12_0_X_2021-05-10-1100/external/slc7_amd64_gcc900/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/runTheMatrix-results/312.0_Pyquen_ZeemumuJets_pt10_2760GeV_2021+Pyquen_ZeemumuJets_pt10_2760GeV_2021+DIGIHI2021MIX+RECOHI2021MIX+HARVESTHI2021PPRECO
----- End Fatal Exception -------------------------------------------------

11634.0

----- Begin Fatal Exception 10-May-2021 18:02:43 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=CSCTriggerPrimitivesProducer label='simCscTriggerPrimitiveDigis'
Exception Message:
edm::FileInPath unable to find file L1Trigger/CSCTriggerPrimitives/data/GEMCSC/CoordinateConversion/GEMCSCLUT_pad_hs_ME1a_even.txt anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33677/14968/CMSSW_12_0_X_2021-05-10-1100/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33677/14968/CMSSW_12_0_X_2021-05-10-1100/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33677/14968/CMSSW_12_0_X_2021-05-10-1100/external/slc7_amd64_gcc900/data:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw-patch/CMSSW_12_0_X_2021-05-10-1100/poison:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw-patch/CMSSW_12_0_X_2021-05-10-1100/src:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw-patch/CMSSW_12_0_X_2021-05-10-1100/external/slc7_amd64_gcc900/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/runTheMatrix-results/11634.0_TTbar_14TeV+2021+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST+ALCA
----- End Fatal Exception -------------------------------------------------

12434.0

----- Begin Fatal Exception 10-May-2021 18:02:43 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=CSCTriggerPrimitivesProducer label='simCscTriggerPrimitiveDigis'
Exception Message:
edm::FileInPath unable to find file L1Trigger/CSCTriggerPrimitives/data/GEMCSC/CoordinateConversion/GEMCSCLUT_pad_hs_ME1a_even.txt anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33677/14968/CMSSW_12_0_X_2021-05-10-1100/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33677/14968/CMSSW_12_0_X_2021-05-10-1100/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33677/14968/CMSSW_12_0_X_2021-05-10-1100/external/slc7_amd64_gcc900/data:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw-patch/CMSSW_12_0_X_2021-05-10-1100/poison:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw-patch/CMSSW_12_0_X_2021-05-10-1100/src:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw-patch/CMSSW_12_0_X_2021-05-10-1100/external/slc7_amd64_gcc900/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/runTheMatrix-results/12434.0_TTbar_14TeV+2023+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST+ALCA
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

RelVals-INPUT

138.2138.2_RunCosmics2020+RunCosmics2020+RECOCOSDEXPRUN3+ALCACOSDEXPRUN3+HARVESTDCEXPRUN3/step2_RunCosmics2020+RunCosmics2020+RECOCOSDEXPRUN3+ALCACOSDEXPRUN3+HARVESTDCEXPRUN3.log
138.1138.1_RunCosmics2020+RunCosmics2020+RECOCOSDRUN3+ALCACOSDRUN3+HARVESTDCRUN3/step2_RunCosmics2020+RunCosmics2020+RECOCOSDRUN3+ALCACOSDRUN3+HARVESTDCRUN3.log
11601.011601.0_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log

Expand to see more relval errors ...

AddOn Tests

hlt_data_PRef

----- Begin Fatal Exception 10-May-2021 17:46:28 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=CSCTriggerPrimitivesProducer label='simCscTriggerPrimitiveDigis'
Exception Message:
edm::FileInPath unable to find file L1Trigger/CSCTriggerPrimitives/data/GEMCSC/CoordinateConversion/GEMCSCLUT_pad_hs_ME1a_even.txt anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33677/14968/CMSSW_12_0_X_2021-05-10-1100/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33677/14968/CMSSW_12_0_X_2021-05-10-1100/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33677/14968/CMSSW_12_0_X_2021-05-10-1100/external/slc7_amd64_gcc900/data:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw-patch/CMSSW_12_0_X_2021-05-10-1100/poison:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw-patch/CMSSW_12_0_X_2021-05-10-1100/src:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw-patch/CMSSW_12_0_X_2021-05-10-1100/external/slc7_amd64_gcc900/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-addon/addOnTests/hlt_data_PRef
----- End Fatal Exception -------------------------------------------------

hlt_mc_PRef

----- Begin Fatal Exception 10-May-2021 17:46:54 CEST-----------------------
An exception of category 'FileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling File::sysopen()
Exception Message:
Failed to open the file 'RelVal_Raw_PRef_MC.root'
   Additional Info:
      [a] Input file file:RelVal_Raw_PRef_MC.root could not be opened.
      [b] open() failed with system error 'No such file or directory' (error code 2)
----- End Fatal Exception -------------------------------------------------

hlt_data_PRef

----- Begin Fatal Exception 10-May-2021 17:47:23 CEST-----------------------
An exception of category 'FileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling File::sysopen()
Exception Message:
Failed to open the file 'RelVal_Raw_PRef_DATA.root'
   Additional Info:
      [a] Input file file:RelVal_Raw_PRef_DATA.root could not be opened.
      [b] open() failed with system error 'No such file or directory' (error code 2)
----- End Fatal Exception -------------------------------------------------

Expand to see more addon errors ...

dildick · 2021-05-10T16:53:30Z

Hi @cecilecaillol. Sorry I should have clarified. Could you test again with cms-data/L1Trigger-CSCTriggerPrimitives#8?

cecilecaillol · 2021-05-10T17:14:51Z

please test with cms-data/L1Trigger-CSCTriggerPrimitives#8

cmsbuild · 2021-05-10T20:13:05Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fcefa3/14973/summary.html
COMMIT: ff05d35
CMSSW: CMSSW_12_0_X_2021-05-10-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33677/14973/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2663174
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2663151
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 155 log files, 37 edm output root files, 37 DQM output files
TriggerResults: no differences found

cecilecaillol · 2021-05-11T15:08:12Z

+l1

cmsbuild · 2021-05-11T15:08:45Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2021-05-11T15:46:07Z

@cms-sw/l1-l2 please also check and sign cms-data/L1Trigger-CSCTriggerPrimitives#8

silviodonato · 2021-05-13T11:33:50Z

+1

Sven Dildick added 3 commits May 10, 2021 08:52

Subdirectories for GEMCSC LUTs

7f81a5d

Consolidate readmes

2bc4df6

Document slope value

ff05d35

cmsbuild added this to the CMSSW_12_0_X milestone May 10, 2021

dildick changed the title ~~GEM-~~ Subdirectories for GEM-CSC LUTs May 10, 2021

cmsbuild added code-checks-pending l1-pending orp-pending pending-signatures tests-pending labels May 10, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels May 10, 2021

cmsbuild added tests-started and removed tests-pending labels May 10, 2021

cmsbuild added tests-rejected and removed tests-started labels May 10, 2021

cmsbuild added requires-external tests-started and removed tests-rejected labels May 10, 2021

cmsbuild added tests-approved and removed tests-started labels May 10, 2021

cmsbuild added fully-signed l1-approved and removed l1-pending pending-signatures labels May 11, 2021

dildick mentioned this pull request May 11, 2021

Mem files for verilog implementation. Organize GEMCSC in subdirs cms-data/L1Trigger-CSCTriggerPrimitives#8

Merged

cmsbuild added orp-approved and removed orp-pending labels May 13, 2021

cmsbuild merged commit af190d4 into cms-sw:master May 13, 2021

silviodonato mentioned this pull request May 13, 2021

Update tag for L1Trigger-CSCTriggerPrimitives to V00-08-00 cms-sw/cmsdist#6904

Merged

dildick deleted the from-CMSSW_12_0_X_2021-05-10-1100-GEMCSC-LUTs branch May 20, 2021 19:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Subdirectories for GEM-CSC LUTs #33677

Subdirectories for GEM-CSC LUTs #33677

dildick commented May 10, 2021 •

edited

cmsbuild commented May 10, 2021

cmsbuild commented May 10, 2021

cecilecaillol commented May 10, 2021

cmsbuild commented May 10, 2021

dildick commented May 10, 2021

cecilecaillol commented May 10, 2021

cmsbuild commented May 10, 2021

cecilecaillol commented May 11, 2021

cmsbuild commented May 11, 2021

qliphy commented May 11, 2021

silviodonato commented May 13, 2021

Subdirectories for GEM-CSC LUTs #33677

Subdirectories for GEM-CSC LUTs #33677

Conversation

dildick commented May 10, 2021 • edited

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented May 10, 2021

cmsbuild commented May 10, 2021

cecilecaillol commented May 10, 2021

cmsbuild commented May 10, 2021

RelVals

RelVals-INPUT

AddOn Tests

dildick commented May 10, 2021

cecilecaillol commented May 10, 2021

cmsbuild commented May 10, 2021

Comparison Summary

cecilecaillol commented May 11, 2021

cmsbuild commented May 11, 2021

qliphy commented May 11, 2021

silviodonato commented May 13, 2021

dildick commented May 10, 2021 •

edited