-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EGamma: Remove Fall17V1 variables from electron table for v9 NanoAOD #33701
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33701/22615
|
A new Pull Request was created by @sroychow (Suvankar Roy Chowdhury) for master. It involves the following packages: PhysicsTools/NanoAOD @cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-69e493/15019/summary.html Comparison SummarySummary:
|
@mariadalfonso @jainshilpi Sorry, I had missed removing one variable https://tinyurl.com/yewurlb5 from the electron DQM. Fixed it in the last commit. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33701/22620
|
Pull request #33701 was updated. @cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please check and sign again. |
please test |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33701/22636
|
Pull request #33701 was updated. @mariadalfonso, @gouskos, @fgolf can you please check and sign again. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-69e493/15044/summary.html Comparison SummarySummary:
|
+xpog changes in the run2_nanoAOD_106Xv1 and run2_nanoAOD_106Xv2 due to the removal of Run1 variables |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
@sroychow please prepare the backport |
+1 |
PR description:
As the title says, this PR removes the Fall17V1 variables from the electron table in NanoAOD. This is intended for NanoAOD v9. But these variables are kept for previous versions of NanoAOD.
PR validation:
Checked with wfs - 136.7722, 136.7952, 136.8522, 136.8523
if this PR is a backport please specify the original PR and why you need to backport that PR:
A backport to 10_6_X will be needed.
cc @jainshilpi @mariadalfonso @gouskos