EGamma: Remove Fall17V1 variables from electron table for v9 NanoAOD

[sroychow]

PR description:

As the title says, this PR removes the Fall17V1 variables from the electron table in NanoAOD. This is intended for NanoAOD v9. But these variables are kept for previous versions of NanoAOD.

PR validation:

Checked with wfs - 136.7722, 136.7952, 136.8522, 136.8523

if this PR is a backport please specify the original PR and why you need to backport that PR:

A backport to 10_6_X will be needed.

cc @jainshilpi @mariadalfonso @gouskos

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33701/22615

• This PR adds an extra 36KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File PhysicsTools/NanoAOD/python/electrons_cff.py modified in PR(s): Calotower -> HCAL rechit for EGM ID variables #33666

[cmsbuild]

A new Pull Request was created by @sroychow (Suvankar Roy Chowdhury) for master.

It involves the following packages:

PhysicsTools/NanoAOD

@cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please review it and eventually sign? Thanks.
@gpetruc, @swertz this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mariadalfonso]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-69e493/15019/summary.html
COMMIT: ebc9d51
CMSSW: CMSSW_12_0_X_2021-05-11-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33701/15019/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 65 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2648114
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2648091
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -1.297 KiB( 36 files compared)
• DQMHistoSizes: changed ( 136.8523 ): -1.297 KiB Physics/NanoAODDQM
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[sroychow]

@mariadalfonso @jainshilpi Sorry, I had missed removing one variable https://tinyurl.com/yewurlb5 from the electron DQM. Fixed it in the last commit.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33701/22620

• This PR adds an extra 36KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File PhysicsTools/NanoAOD/python/electrons_cff.py modified in PR(s): Calotower -> HCAL rechit for EGM ID variables #33666

[cmsbuild]

Pull request #33701 was updated. @cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please check and sign again.

[gouskos]

please test

[mariadalfonso]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33701/22636

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File PhysicsTools/NanoAOD/python/electrons_cff.py modified in PR(s): Calotower -> HCAL rechit for EGM ID variables #33666

[cmsbuild]

Pull request #33701 was updated. @mariadalfonso, @gouskos, @fgolf can you please check and sign again.

[gouskos]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-69e493/15044/summary.html
COMMIT: 77f2c38
CMSSW: CMSSW_12_0_X_2021-05-11-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33701/15044/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 191 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2648114
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2648091
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -3.655 KiB( 36 files compared)
• DQMHistoSizes: changed ( 1325.81 ): -2.209 KiB Physics/NanoAODDQM
• DQMHistoSizes: changed ( 136.8523 ): -1.446 KiB Physics/NanoAODDQM
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[mariadalfonso]

+xpog

changes in the run2_nanoAOD_106Xv1 and run2_nanoAOD_106Xv2 due to the removal of Run1 variables
about 1% size gain

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[mariadalfonso]

@sroychow please prepare the backport

[silviodonato]

+1