Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made PoolDBOutputService compatible with threaded framework #3371

Conversation

Dr15Jones
Copy link
Contributor

Initial attempt at making PoolDBOutputService work with the threaded
framework. The code now uses the new ActivityRegistry signals and
has a recursive mutex around the function which change internal state.
Several assumptions have been made

  1. only one Run and Lumi are being processed in the job. This will be
    true for CMSSW_7_1_X but not in the future;
  2. the calls to the DB are thread safe;
  3. time based IOVs are only set during Event processing

In addition, the session() method was not removed however I am
fairly certain a caller could not use the return value in a thread
safe manner.

Initial attempt at making PoolDBOutputService work with the threaded
framework. The code now uses the new ActivityRegistry signals and
has a recursive mutex around the function which change internal state.
Several assumptions have been made
1) only one Run and Lumi are being processed in the job. This will be
true for CMSSW_7_1_X but not in the future;
2) the calls to the DB are thread safe;
3) time based IOVs are only set during Event processing

In addition, the session() method was not removed however I am
fairly certain a caller could not use the return value in a thread
safe manner.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_1_X.

Made PoolDBOutputService compatible with threaded framework

It involves the following packages:

CondCore/DBOutputService

@apfeiffer1, @diguida, @cmsbuild, @nclopezo, @rcastello, @ggovi, @Degano can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@apfeiffer1
Copy link
Contributor

+1
thanks, Chris !

On Thu, Apr 17, 2014 at 12:50 PM, cmsbuild notifications@github.com wrote:

Comparison is ready

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3371/934/summary.html


Reply to this email directly or view it on GitHubhttps://github.com//pull/3371#issuecomment-40702256
.

Thanks,
cheers, andreas

@Dr15Jones
Copy link
Contributor Author

@rcastello @diguida ping?

@diguida
Copy link
Contributor

diguida commented Apr 17, 2014

+1
Thanks

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request Apr 17, 2014
…ibleWithThreadedFramework

Multithreading -- Made PoolDBOutputService compatible with threaded framework
@ktf ktf merged commit 16c3d6f into cms-sw:CMSSW_7_1_X Apr 17, 2014
@Dr15Jones Dr15Jones deleted the makePoolDBOutputServiceCompatibleWithThreadedFramework branch April 23, 2014 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants