Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of JERC tags for UL16 #33710

Merged
merged 2 commits into from May 27, 2021
Merged

Conversation

malbouis
Copy link
Contributor

@malbouis malbouis commented May 12, 2021

PR description:

This PR is to update the Run 2 offline data and MC Global Tags with the jet energy resolution and corrections for the UL16 MiniAODv2 production.

The tags were updated according to this request: https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4401.html

GT differences:

2016 realistic pre-VFP era
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_mcRun2_asymptotic_preVFP_v10/106X_mcRun2_asymptotic_preVFP_v11

2016 realistic post-VFP era
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_mcRun2_asymptotic_v16/106X_mcRun2_asymptotic_v17

Offline data
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_dataRun2_v33/106X_dataRun2_v35

Offline data relval
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/106X_dataRun2_relval_v31/106X_dataRun2_relval_v33

PR validation:

runTheMatrix.py -l limited,136.772,136.783,136.852 --ibeos

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is not a backport but it will be forward ported to master.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @malbouis for CMSSW_10_6_X.

It involves the following packages:

Configuration/AlCa

@malbouis, @yuanchao, @cmsbuild, @tlampen, @pohsun, @francescobrivio can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@malbouis
Copy link
Contributor Author

test parameters:

  • workflow = 136.772,136.783,136.852

@malbouis
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-623055/15031/summary.html
COMMIT: 493e5c1
CMSSW: CMSSW_10_6_X_2021-05-12-1100/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33710/15031/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2860 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 3215557
  • DQMHistoTests: Total failures: 7119
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3208104
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 143 log files, 29 edm output root files, 35 DQM output files
  • TriggerResults: no differences found

@yuanchao
Copy link
Contributor

+1

  • update JERC tags; only configuration modified
  • WF tests and unit tests all passed

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@francescobrivio
Copy link
Contributor

hold

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @francescobrivio
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@francescobrivio
Copy link
Contributor

There is still some ongoing (private) discussion on wether the JERC tags are composed as expected or not.

@cmsbuild
Copy link
Contributor

Pull request #33710 was updated. @malbouis, @yuanchao, @cmsbuild, @tlampen, @pohsun, @francescobrivio can you please check and sign again.

@malbouis
Copy link
Contributor Author

test parameters:

  • workflow = 136.772,136.783,136.852

@malbouis
Copy link
Contributor Author

please test

@francescobrivio
Copy link
Contributor

unhold

@cmsbuild cmsbuild removed the hold label May 25, 2021
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-623055/15300/summary.html
COMMIT: 4e16ec7
CMSSW: CMSSW_10_6_X_2021-05-25-1700/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33710/15300/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1145 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 3215552
  • DQMHistoTests: Total failures: 3246
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211972
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 143 log files, 29 edm output root files, 35 DQM output files
  • TriggerResults: no differences found

@francescobrivio
Copy link
Contributor

+alca

  • diffs in comparison are expected as 2016 JERC tags are updated
  • run1 and 2017/2018 history preserved

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented May 27, 2021

+1

@cmsbuild cmsbuild merged commit 9a1c192 into cms-sw:CMSSW_10_6_X May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants