Remove boost and root deps from SimDataFormats/EncodedEventId

[guitargeek]

Some dependency cleaning. No backport intended.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33715/22640

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

SimDataFormats/EncodedEventId

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@apsallid, @ebrondol, @rovere, @fabiocos, @lecriste this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[silviodonato]

please test

[cmsbuild]

-1

Failed Tests: Build HeaderConsistency
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0b47c2/15074/summary.html
COMMIT: dba6b5a
CMSSW: CMSSW_12_0_X_2021-05-12-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33715/15074/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

Copying tmp/slc7_amd64_gcc900/src/GeneratorInterface/Hydjet2Interface/src/GeneratorInterfaceHydjet2Interface/libGeneratorInterfaceHydjet2Interface.so to productstore area:
Leaving library rule at GeneratorInterface/Hydjet2Interface
Entering library rule at src/GeneratorInterface/Hydjet2Interface/test
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-12-2300/src/GeneratorInterface/Hydjet2Interface/test/Hydjet2Analyzer.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-12-2300/src/GeneratorInterface/Hydjet2Interface/test/Hydjet2Analyzer.cc: In member function 'virtual void Hydjet2Analyzer::analyze(const edm::Event&, const edm::EventSetup&)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-12-2300/src/GeneratorInterface/Hydjet2Interface/test/Hydjet2Analyzer.cc:554:23: error: 'Cos' is not a member of 'TMath'
  554 |           v2 = TMath::Cos(2 * (phiTrue));
      |                       ^~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-12-2300/src/GeneratorInterface/Hydjet2Interface/test/Hydjet2Analyzer.cc:555:23: error: 'Cos' is not a member of 'TMath'
  555 |           v3 = TMath::Cos(3 * (phiTrue - phi3));
      |                       ^~~


[cmsbuild]

Pull request #33715 was updated. @SiewYan, @civanch, @mkirsano, @mdhildreth, @rekovic, @agrohsje, @alberto-sanchez, @cecilecaillol, @GurpreetSinghChahal can you please check and sign again.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33715/22661

• This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33715/22661/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33715/22661/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0b47c2/15121/summary.html
COMMIT: 35b35db
CMSSW: CMSSW_12_0_X_2021-05-15-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33715/15121/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS Clang-Tidy warnings: There are Clang-Tidy warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0b47c2/15121/llvm-analysis/cmsclangtidy.txt for details.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 183 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2648242
• DQMHistoTests: Total failures: 1041
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2647179
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[cecilecaillol]

+l1

[civanch]

@guitargeek , it seems FastSim is affected by this clean-up. @sbein , can you, please, have a look?

[guitargeek]

Hi @sbein, are these changes OK for you?

[civanch]

+1

observed difference likely connected with small differences in computation of cosine.
I would suggest to merge this PR.

[guitargeek]

Thanks! What about generators and upgrade? @agrohsje, @alberto-sanchez, @kpedro88, @srimanob.

[agrohsje]

+generators

[srimanob]

+Upgrade

Technical PR to remove boost and root dependency. Small changes have been observed due to the calculation of trigonometry function.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1