LowPtElectrons: support for UL re-MINIAOD and BParking UL RE-RECO #33725

bainbrid · 2021-05-13T15:45:00Z

PR description:

This PR adds the missing recoGsfElectrons_lowPtGsfElectronsPreRegression collection to AOD.
This PR provides support for the re-MINIAOD of both non-bParking (i.e. standard) and BParking Ultra Legacy RECO/AOD samples produced in 10_6_X. It schedules the application of energy regression and the 2020Nov28 ID model by using the modifier logic run2_miniAOD_UL.
This PR raises the minimum pT of input tracks considered by the ElectronSeed step from 0.5 to 1.0 GeV for the bParking era. Performance details are provided in the PR description for LowPtElectrons: final energy regression and ID (back port of 32391) #33589. This change and it's motivation was presented recently to XPOG, slides 8 and 9.
This PR adds a new ID weights file (2021May17) for use with a BParking UL re-RECO or re-MINIAOD campaign. There is no appreciable CPU load (w.r.t. the original model), the memory footprint will reduce (due to the smaller weights file), and the RECO/AOD event size is unaffected. The 2021May17 performance can be found in the right plot of slide 5 here.

All non-RECO related changes listed above are included in the 10_6_X back port PR #33589.

This PR depends on cms-data/RecoEgamma-ElectronIdentification#21, which adds the weights file for the 2021May17 model.

PR validation:

This PR has been tested locally with wfs 1304.182, 1325.518, 136.88811, 136.898.
The behaviour for the "no-change policy" logic (~bParking & run2_miniAOD_UL) has also been tested locally.

bainbrid · 2021-05-13T15:45:25Z

@crovelli @cavalari @jainshilpi @lfinco

cmsbuild · 2021-05-13T15:52:20Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33725/22658

This PR adds an extra 16KB to repository

cmsbuild · 2021-05-13T15:52:45Z

A new Pull Request was created by @bainbrid for master.

It involves the following packages:

PhysicsTools/PatAlgos
RecoEgamma/Configuration
RecoEgamma/EgammaElectronProducers

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@emilbols, @gouskos, @jainshilpi, @hatakeyamak, @rappoccio, @mbluj, @varuns23, @seemasharmafnal, @mmarionncern, @ahinzmann, @lgray, @jdolen, @ferencek, @Sam-Harper, @rovere, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @mariadalfonso, @clelange, @swozniewski, @JyothsnaKomaragiri, @sobhatta, @lecriste, @afiqaize, @gpetruc, @andrzejnovak, @ram1123 this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

slava77 · 2021-05-14T00:24:07Z

@cmsbuild please test

cmsbuild · 2021-05-14T01:41:28Z

-1

Failed Tests: RelVals RelVals-INPUT AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e9d220/15081/summary.html
COMMIT: 7c83ec0
CMSSW: CMSSW_12_0_X_2021-05-13-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33725/15081/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

312.0

----- Begin Fatal Exception 14-May-2021 02:52:35 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=CSCTriggerPrimitivesProducer label='simCscTriggerPrimitiveDigis'
Exception Message:
edm::FileInPath unable to find file L1Trigger/CSCTriggerPrimitives/data/GEMCSC/GEMCSCLUT_pad_hs_ME1a_even.txt anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33725/15081/CMSSW_12_0_X_2021-05-13-1100/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33725/15081/CMSSW_12_0_X_2021-05-13-1100/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33725/15081/CMSSW_12_0_X_2021-05-13-1100/external/slc7_amd64_gcc900/data:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_X_2021-05-13-1100/src:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_X_2021-05-13-1100/external/slc7_amd64_gcc900/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/runTheMatrix-results/312.0_Pyquen_ZeemumuJets_pt10_2760GeV_2021+Pyquen_ZeemumuJets_pt10_2760GeV_2021+DIGIHI2021MIX+RECOHI2021MIX+HARVESTHI2021PPRECO
----- End Fatal Exception -------------------------------------------------

11634.0

----- Begin Fatal Exception 14-May-2021 03:03:51 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=CSCTriggerPrimitivesProducer label='simCscTriggerPrimitiveDigis'
Exception Message:
edm::FileInPath unable to find file L1Trigger/CSCTriggerPrimitives/data/GEMCSC/GEMCSCLUT_pad_hs_ME1a_even.txt anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33725/15081/CMSSW_12_0_X_2021-05-13-1100/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33725/15081/CMSSW_12_0_X_2021-05-13-1100/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33725/15081/CMSSW_12_0_X_2021-05-13-1100/external/slc7_amd64_gcc900/data:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_X_2021-05-13-1100/src:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_X_2021-05-13-1100/external/slc7_amd64_gcc900/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/runTheMatrix-results/11634.0_TTbar_14TeV+2021+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST+ALCA
----- End Fatal Exception -------------------------------------------------

12434.0

----- Begin Fatal Exception 14-May-2021 03:03:52 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=CSCTriggerPrimitivesProducer label='simCscTriggerPrimitiveDigis'
Exception Message:
edm::FileInPath unable to find file L1Trigger/CSCTriggerPrimitives/data/GEMCSC/GEMCSCLUT_pad_hs_ME1a_even.txt anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33725/15081/CMSSW_12_0_X_2021-05-13-1100/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33725/15081/CMSSW_12_0_X_2021-05-13-1100/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33725/15081/CMSSW_12_0_X_2021-05-13-1100/external/slc7_amd64_gcc900/data:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_X_2021-05-13-1100/src:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_X_2021-05-13-1100/external/slc7_amd64_gcc900/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/runTheMatrix-results/12434.0_TTbar_14TeV+2023+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST+ALCA
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

RelVals-INPUT

11601.011601.0_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log
11602.011602.0_SingleElectronPt35+2021+SingleElectronPt35_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt35+2021+SingleElectronPt35_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log
11604.011604.0_SingleGammaPt10+2021+SingleGammaPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleGammaPt10+2021+SingleGammaPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log

Expand to see more relval errors ...

AddOn Tests

hlt_data_PRef

----- Begin Fatal Exception 14-May-2021 02:43:27 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=CSCTriggerPrimitivesProducer label='simCscTriggerPrimitiveDigis'
Exception Message:
edm::FileInPath unable to find file L1Trigger/CSCTriggerPrimitives/data/GEMCSC/GEMCSCLUT_pad_hs_ME1a_even.txt anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33725/15081/CMSSW_12_0_X_2021-05-13-1100/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33725/15081/CMSSW_12_0_X_2021-05-13-1100/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33725/15081/CMSSW_12_0_X_2021-05-13-1100/external/slc7_amd64_gcc900/data:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_X_2021-05-13-1100/src:/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_X_2021-05-13-1100/external/slc7_amd64_gcc900/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-addon/addOnTests/hlt_data_PRef
----- End Fatal Exception -------------------------------------------------

hlt_mc_PRef

----- Begin Fatal Exception 14-May-2021 02:44:01 CEST-----------------------
An exception of category 'FileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling File::sysopen()
Exception Message:
Failed to open the file 'RelVal_Raw_PRef_MC.root'
   Additional Info:
      [a] Input file file:RelVal_Raw_PRef_MC.root could not be opened.
      [b] open() failed with system error 'No such file or directory' (error code 2)
----- End Fatal Exception -------------------------------------------------

hlt_data_PRef

----- Begin Fatal Exception 14-May-2021 02:44:18 CEST-----------------------
An exception of category 'FileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling File::sysopen()
Exception Message:
Failed to open the file 'RelVal_Raw_PRef_DATA.root'
   Additional Info:
      [a] Input file file:RelVal_Raw_PRef_DATA.root could not be opened.
      [b] open() failed with system error 'No such file or directory' (error code 2)
----- End Fatal Exception -------------------------------------------------

Expand to see more addon errors ...

perrotta · 2021-05-14T05:53:55Z

@cmsbuild please test
(CMSSW_12_0_X_2021-05-13-2300 shouldn't show those errors)

cmsbuild · 2021-05-14T08:25:34Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e9d220/15082/summary.html
COMMIT: 7c83ec0
CMSSW: CMSSW_12_0_X_2021-05-13-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33725/15082/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 7 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2648242
DQMHistoTests: Total failures: 12
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2648207
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 36 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 155 log files, 37 edm output root files, 37 DQM output files
TriggerResults: no differences found

bainbrid · 2021-05-27T10:38:33Z

Hi @slava77 the updates today to this PR reflect the changes noted. #33589 (comment) to maintain consistency b/w 10_6_X and master.

slava77 · 2021-05-27T22:16:24Z

PhysicsTools/PatAlgos/python/producersLayer1/lowPtElectronProducer_cff.py

-# Append to Task
-run2_miniAOD_UL.toReplaceWith(makePatLowPtElectronsTask,_makePatLowPtElectronsTask)
-
+(~bParking & run2_miniAOD_UL).toReplaceWith(makePatLowPtElectronsTask,_makePatLowPtElectronsTask)


it looks like this update assumes that bParking UL AOD is made with a correct ID.
I guess this reconfiguration is perhaps pending resolution of actually deploying LowPtElectrons/LowPtElectrons_ID_2021May17.root in the UL bParking production

If I understand you correctly, you're saying that the logic above implicitly assumes the the BParking UL RE-RECO will use May17, and so nothing is required on the part of re-miniAOD (to e.g. update the ID).

If so, you are correct and I am updating the back port now with the logic for (bParking & run2_miniAOD_UL) that will indeed rerun the ID (May17). This change will be added to this PR.

slava77 · 2021-05-27T22:19:10Z

Hi @slava77 the updates today to this PR reflect the changes noted. #33589 (comment) to maintain consistency b/w 10_6_X and master.

sorry, I'm missing an update in this PR.
I see that the title was changed and cms-data/RecoEgamma-ElectronIdentification#21 mentioned this PR, but there were no visible updates here (yet).

RecoEgamma/Configuration/python/RecoEgamma_EventContent_cff.py

Co-authored-by: Slava Krutelyov <slava77@gmail.com>

cmsbuild · 2021-06-02T21:54:11Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33725/23039

This PR adds an extra 12KB to repository
Found files with invalid states:
- RecoEgamma/EgammaElectronProducers/python/lowPtGsfElectronID_cff.py:
  - Added: a8669ee
  - Deleted: 647898b
There are other open Pull requests which might conflict with changes you have proposed:
- File RecoEgamma/EgammaElectronProducers/plugins/LowPtGsfElectronIDProducer.cc modified in PR(s): LowPtElectrons: NanoAOD integration #33817

cmsbuild · 2021-06-02T21:54:35Z

Pull request #33725 was updated. @perrotta, @jpata, @cmsbuild, @slava77 can you please check and sign again.

slava77 · 2021-06-02T22:38:22Z

test parameters:

slava77 · 2021-06-02T22:39:39Z

@cmsbuild please test

cmsbuild · 2021-06-03T02:20:48Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e9d220/15576/summary.html
COMMIT: c91e0e9
CMSSW: CMSSW_12_0_X_2021-06-02-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33725/15576/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS Clang-Tidy warnings: There are Clang-Tidy warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e9d220/15576/llvm-analysis/cmsclangtidy.txt for details.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 3 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2650486
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2650457
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 36 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 155 log files, 37 edm output root files, 37 DQM output files
TriggerResults: no differences found

slava77 · 2021-06-03T02:54:11Z

+reconstruction

for #33725 c91e0e9

code changes are in line with the PR description and the follow up review:
- this PR is also consistent with the "backport" PR LowPtElectrons: final energy regression and ID (back port of 32391) #33589
jenkins tests pass and comparisons with the baseline show no differences (the bParking workflow is not in the cms-bot tests)
local test with 136.898 (bParking rereco from RAW) show 40-50% reduction in products related to lowPt electrons due to the increased pt requirement
- total CPU cost of the reco step in 136.898 is down by 12% , driven by close to a factor of 2 reduction in modules matching lowPtGsf*|owPtEle*|gsfTracksOpen* name pattern
- output size is down by about 4% in AOD format

cmsbuild · 2021-06-03T02:54:35Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2021-06-03T06:32:51Z

+1

cmsbuild added this to the CMSSW_12_0_X milestone May 13, 2021

cmsbuild added code-checks-pending orp-pending pending-signatures reconstruction-pending tests-pending labels May 13, 2021

bainbrid mentioned this pull request May 13, 2021

LowPtElectrons: final energy regression and ID (back port of 32391) #33589

Merged

cmsbuild added code-checks-approved and removed code-checks-pending labels May 13, 2021

cmsbuild added tests-started and removed tests-pending labels May 14, 2021

cmsbuild added tests-rejected and removed tests-started labels May 14, 2021

cmsbuild added tests-started and removed tests-rejected labels May 14, 2021

cmsbuild added tests-approved and removed tests-started labels May 14, 2021

bainbrid mentioned this pull request May 27, 2021

LowPtElectrons: 2021May17 model for 12_0_X cms-data/RecoEgamma-ElectronIdentification#21

Merged

bainbrid changed the title ~~LowPtElectrons: support for UL re-miniAOD; bParking track pT threshold~~ LowPtElectrons: support for UL re-MINIAOD and BParking UL RE-RECO May 27, 2021

slava77 reviewed May 27, 2021

View reviewed changes

cmsbuild removed the code-checks-approved label May 27, 2021

slava77 reviewed Jun 1, 2021

View reviewed changes

RecoEgamma/Configuration/python/RecoEgamma_EventContent_cff.py Outdated Show resolved Hide resolved

slava77 mentioned this pull request Jun 2, 2021

features for bParking UL rereco and miniAOD in 10_6_X (10_6_26?) #33917

Closed

14 tasks

Update RecoEgamma/Configuration/python/RecoEgamma_EventContent_cff.py

c91e0e9

Co-authored-by: Slava Krutelyov <slava77@gmail.com>

cmsbuild added code-checks-pending tests-pending and removed code-checks-approved tests-approved labels Jun 2, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 2, 2021

cmsbuild mentioned this pull request Jun 2, 2021

LowPtElectrons: NanoAOD integration #33817

Merged

cmsbuild removed the requires-external label Jun 2, 2021

cmsbuild added tests-started and removed tests-pending labels Jun 2, 2021

cmsbuild added tests-approved and removed tests-started labels Jun 3, 2021

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels Jun 3, 2021

cmsbuild added orp-approved and removed orp-pending labels Jun 3, 2021

cmsbuild merged commit 67f6b89 into cms-sw:master Jun 3, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LowPtElectrons: support for UL re-MINIAOD and BParking UL RE-RECO #33725

LowPtElectrons: support for UL re-MINIAOD and BParking UL RE-RECO #33725

bainbrid commented May 13, 2021 •

edited

bainbrid commented May 13, 2021

cmsbuild commented May 13, 2021

cmsbuild commented May 13, 2021

slava77 commented May 14, 2021

cmsbuild commented May 14, 2021

perrotta commented May 14, 2021

cmsbuild commented May 14, 2021

bainbrid commented May 27, 2021

slava77 May 27, 2021

bainbrid May 27, 2021

slava77 commented May 27, 2021

cmsbuild commented Jun 2, 2021

cmsbuild commented Jun 2, 2021

slava77 commented Jun 2, 2021

slava77 commented Jun 2, 2021

cmsbuild commented Jun 3, 2021

slava77 commented Jun 3, 2021

cmsbuild commented Jun 3, 2021

qliphy commented Jun 3, 2021

LowPtElectrons: support for UL re-MINIAOD and BParking UL RE-RECO #33725

LowPtElectrons: support for UL re-MINIAOD and BParking UL RE-RECO #33725

Conversation

bainbrid commented May 13, 2021 • edited

PR description:

PR validation:

bainbrid commented May 13, 2021

cmsbuild commented May 13, 2021

cmsbuild commented May 13, 2021

slava77 commented May 14, 2021

cmsbuild commented May 14, 2021

RelVals

RelVals-INPUT

AddOn Tests

perrotta commented May 14, 2021

cmsbuild commented May 14, 2021

Comparison Summary

bainbrid commented May 27, 2021

slava77 May 27, 2021

Choose a reason for hiding this comment

bainbrid May 27, 2021

Choose a reason for hiding this comment

slava77 commented May 27, 2021

cmsbuild commented Jun 2, 2021

cmsbuild commented Jun 2, 2021

slava77 commented Jun 2, 2021

slava77 commented Jun 2, 2021

cmsbuild commented Jun 3, 2021

Comparison Summary

slava77 commented Jun 3, 2021

cmsbuild commented Jun 3, 2021

qliphy commented Jun 3, 2021

bainbrid commented May 13, 2021 •

edited