-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added link needed for debug build of SimTransport/PPSProtonTransport #33739
Added link needed for debug build of SimTransport/PPSProtonTransport #33739
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33739/22685
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: SimTransport/PPSProtonTransport @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a81f60/15109/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
When compiled with -DEDM_ML_DEBUG there was a missing symbol which comes from SimDataFormats/Forward.
PR validation:
The code now compiles and links with -DEDM_ML_DEBUG set.